From 884870461d597c06b746cb99ff305712d3004299 Mon Sep 17 00:00:00 2001 From: Jorge Canizales Date: Sun, 21 Jun 2015 21:59:37 -0700 Subject: [PATCH] Document why a grpc_op ivar, and the role of -finish --- src/objective-c/GRPCClient/private/GRPCWrappedCall.h | 1 + src/objective-c/GRPCClient/private/GRPCWrappedCall.m | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/objective-c/GRPCClient/private/GRPCWrappedCall.h b/src/objective-c/GRPCClient/private/GRPCWrappedCall.h index adba624d5b4..c08aefc6a8f 100644 --- a/src/objective-c/GRPCClient/private/GRPCWrappedCall.h +++ b/src/objective-c/GRPCClient/private/GRPCWrappedCall.h @@ -38,6 +38,7 @@ @interface GRPCOperation : NSObject @property(nonatomic, readonly) grpc_op op; +// Guaranteed to be called when the operation has finished. - (void)finish; @end diff --git a/src/objective-c/GRPCClient/private/GRPCWrappedCall.m b/src/objective-c/GRPCClient/private/GRPCWrappedCall.m index 5723de2e9c0..4ccd5723c61 100644 --- a/src/objective-c/GRPCClient/private/GRPCWrappedCall.m +++ b/src/objective-c/GRPCClient/private/GRPCWrappedCall.m @@ -43,6 +43,8 @@ @implementation GRPCOperation { @protected + // Most operation subclasses don't set any flags in the grpc_op, and rely on the flag member being + // initialized to zero. grpc_op _op; void(^_handler)(); }