[chttp2] Disable overload_protection experiment (#34767)

This causes breakages in multiple tests. The event_engine_listener tests
are particularly sensitive to the breakage.
pull/34748/head^2
AJ Heller 1 year ago committed by GitHub
parent 598ccb1512
commit 872c7dbed5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      bazel/experiments.bzl
  2. 6
      src/core/lib/experiments/experiments.cc
  3. 9
      src/core/lib/experiments/experiments.h
  4. 2
      src/core/lib/experiments/rollouts.yaml

@ -39,6 +39,7 @@ EXPERIMENTS = {
],
"flow_control_test": [
"multiping",
"overload_protection",
"peer_state_based_framing",
"red_max_concurrent_streams",
"rstpit",
@ -88,7 +89,6 @@ EXPERIMENTS = {
"chttp2_batch_requests",
"chttp2_offload_on_rst_stream",
"lazier_stream_updates",
"overload_protection",
"write_size_cap",
"write_size_policy",
],
@ -129,6 +129,7 @@ EXPERIMENTS = {
],
"flow_control_test": [
"multiping",
"overload_protection",
"peer_state_based_framing",
"red_max_concurrent_streams",
"rstpit",
@ -172,7 +173,6 @@ EXPERIMENTS = {
"chttp2_batch_requests",
"chttp2_offload_on_rst_stream",
"lazier_stream_updates",
"overload_protection",
"write_size_cap",
"write_size_policy",
],
@ -224,6 +224,7 @@ EXPERIMENTS = {
],
"flow_control_test": [
"multiping",
"overload_protection",
"peer_state_based_framing",
"red_max_concurrent_streams",
"rstpit",
@ -270,7 +271,6 @@ EXPERIMENTS = {
"chttp2_batch_requests",
"chttp2_offload_on_rst_stream",
"lazier_stream_updates",
"overload_protection",
"write_size_cap",
"write_size_policy",
],

@ -240,7 +240,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
{"multiping", description_multiping, additional_constraints_multiping,
false, true},
{"overload_protection", description_overload_protection,
additional_constraints_overload_protection, true, true},
additional_constraints_overload_protection, false, true},
{"peer_state_based_framing", description_peer_state_based_framing,
additional_constraints_peer_state_based_framing, false, true},
{"pick_first_happy_eyeballs", description_pick_first_happy_eyeballs,
@ -521,7 +521,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
{"multiping", description_multiping, additional_constraints_multiping,
false, true},
{"overload_protection", description_overload_protection,
additional_constraints_overload_protection, true, true},
additional_constraints_overload_protection, false, true},
{"peer_state_based_framing", description_peer_state_based_framing,
additional_constraints_peer_state_based_framing, false, true},
{"pick_first_happy_eyeballs", description_pick_first_happy_eyeballs,
@ -802,7 +802,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
{"multiping", description_multiping, additional_constraints_multiping,
false, true},
{"overload_protection", description_overload_protection,
additional_constraints_overload_protection, true, true},
additional_constraints_overload_protection, false, true},
{"peer_state_based_framing", description_peer_state_based_framing,
additional_constraints_peer_state_based_framing, false, true},
{"pick_first_happy_eyeballs", description_pick_first_happy_eyeballs,

@ -91,8 +91,7 @@ inline bool IsMemoryPressureControllerEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_MONITORING_EXPERIMENT
inline bool IsMonitoringExperimentEnabled() { return true; }
inline bool IsMultipingEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_OVERLOAD_PROTECTION
inline bool IsOverloadProtectionEnabled() { return true; }
inline bool IsOverloadProtectionEnabled() { return false; }
inline bool IsPeerStateBasedFramingEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_PICK_FIRST_HAPPY_EYEBALLS
inline bool IsPickFirstHappyEyeballsEnabled() { return true; }
@ -167,8 +166,7 @@ inline bool IsMemoryPressureControllerEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_MONITORING_EXPERIMENT
inline bool IsMonitoringExperimentEnabled() { return true; }
inline bool IsMultipingEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_OVERLOAD_PROTECTION
inline bool IsOverloadProtectionEnabled() { return true; }
inline bool IsOverloadProtectionEnabled() { return false; }
inline bool IsPeerStateBasedFramingEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_PICK_FIRST_HAPPY_EYEBALLS
inline bool IsPickFirstHappyEyeballsEnabled() { return true; }
@ -242,8 +240,7 @@ inline bool IsMemoryPressureControllerEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_MONITORING_EXPERIMENT
inline bool IsMonitoringExperimentEnabled() { return true; }
inline bool IsMultipingEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_OVERLOAD_PROTECTION
inline bool IsOverloadProtectionEnabled() { return true; }
inline bool IsOverloadProtectionEnabled() { return false; }
inline bool IsPeerStateBasedFramingEnabled() { return false; }
#define GRPC_EXPERIMENT_IS_INCLUDED_PICK_FIRST_HAPPY_EYEBALLS
inline bool IsPickFirstHappyEyeballsEnabled() { return true; }

@ -89,7 +89,7 @@
- name: monitoring_experiment
default: true
- name: overload_protection
default: true
default: false
- name: peer_state_based_framing
default: false
- name: pick_first_happy_eyeballs

Loading…
Cancel
Save