Prevented composing insecure credentials

pull/3558/head
murgatroid99 9 years ago
parent 5f709ca2a4
commit 86ef17ada9
  1. 4
      src/node/ext/channel_credentials.cc

@ -181,6 +181,10 @@ NAN_METHOD(ChannelCredentials::Compose) {
} }
ChannelCredentials *self = ObjectWrap::Unwrap<ChannelCredentials>( ChannelCredentials *self = ObjectWrap::Unwrap<ChannelCredentials>(
info.This()); info.This());
if (self->wrapped_credentials == NULL) {
return Nan::ThrowTypeError(
"Cannot compose insecure credential");
}
CallCredentials *other = ObjectWrap::Unwrap<CallCredentials>( CallCredentials *other = ObjectWrap::Unwrap<CallCredentials>(
Nan::To<Object>(info[0]).ToLocalChecked()); Nan::To<Object>(info[0]).ToLocalChecked());
grpc_credentials *creds = grpc_composite_credentials_create( grpc_credentials *creds = grpc_composite_credentials_create(

Loading…
Cancel
Save