resolve comments

BUILD

@@ -717,7 +717,6 @@ cc_library(
 cc_library(
   name = "grpc++_unsecure",
   srcs = [
-    "src/cpp/common/insecure_auth_context.h",
     "src/cpp/client/channel.h",
     "src/cpp/common/create_auth_context.h",
     "src/cpp/server/thread_pool.h",

build.json

@@ -619,9 +619,6 @@
       "name": "grpc++_unsecure",
       "build": "all",
       "language": "c++",
-      "headers": [
-        "src/cpp/common/insecure_auth_context.h"
-      ],
       "src": [
         "src/cpp/common/insecure_create_auth_context.cc"
       ],

include/grpc++/client_context.h

@@ -108,7 +108,7 @@ class ClientContext {
     creds_ = creds;
   }
 
-  std::unique_ptr<const AuthContext> auth_context() const;
+  std::shared_ptr<const AuthContext> auth_context() const;
 
   void TryCancel();
 
@@ -157,6 +157,7 @@ class ClientContext {
   gpr_timespec deadline_;
   grpc::string authority_;
   std::shared_ptr<Credentials> creds_;
+  mutable std::shared_ptr<const AuthContext> auth_context_;
   std::multimap<grpc::string, grpc::string> send_initial_metadata_;
   std::multimap<grpc::string, grpc::string> recv_initial_metadata_;
   std::multimap<grpc::string, grpc::string> trailing_metadata_;

include/grpc++/server_context.h

@@ -99,7 +99,9 @@ class ServerContext {
     return client_metadata_;
   }
 
-  std::unique_ptr<const AuthContext> auth_context() const;
+  std::shared_ptr<const AuthContext> auth_context() const {
+    return auth_context_;
+  }
 
  private:
   friend class ::grpc::Server;
@@ -137,12 +139,15 @@ class ServerContext {
   ServerContext(gpr_timespec deadline, grpc_metadata* metadata,
                 size_t metadata_count);
 
+  void set_call(grpc_call* call);
+
   CompletionOp* completion_op_;
 
   gpr_timespec deadline_;
   grpc_call* call_;
   CompletionQueue* cq_;
   bool sent_initial_metadata_;
+  std::shared_ptr<const AuthContext> auth_context_;
   std::multimap<grpc::string, grpc::string> client_metadata_;
   std::multimap<grpc::string, grpc::string> initial_metadata_;
   std::multimap<grpc::string, grpc::string> trailing_metadata_;

src/cpp/client/client_context.cc

@@ -76,8 +76,11 @@ void ClientContext::set_call(grpc_call* call,
   }
 }
 
-std::unique_ptr<const AuthContext> ClientContext::auth_context() const {
-  return CreateAuthContext(call_);
+std::shared_ptr<const AuthContext> ClientContext::auth_context() const {
+  if (auth_context_.get() == nullptr) {
+    auth_context_ = CreateAuthContext(call_);
+  }
+  return auth_context_;
 }
 
 void ClientContext::TryCancel() {

src/cpp/common/insecure_auth_context.h

@@ -1,59 +0,0 @@
-/*
- *
- * Copyright 2015, Google Inc.
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- *     * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- *     * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- *
- */
-
-#ifndef GRPC_INTERNAL_CPP_COMMON_INSECURE_AUTH_CONTEXT_H
-#define GRPC_INTERNAL_CPP_COMMON_INSECURE_AUTH_CONTEXT_H
-
-#include <grpc++/auth_context.h>
-
-namespace grpc {
-
-class InsecureAuthContext : public AuthContext {
- public:
-  ~InsecureAuthContext() GRPC_OVERRIDE {}
-
-  std::vector<grpc::string> GetPeerIdentity() const GRPC_OVERRIDE {
-    return std::vector<grpc::string>();
-  }
-
-  grpc::string GetPeerIdentityPropertyName() const GRPC_OVERRIDE { return ""; }
-
-  std::vector<grpc::string> FindPropertyValues(const grpc::string& name) const
-      GRPC_OVERRIDE {
-    return std::vector<grpc::string>();
-  }
-};
-
-}  // namespace grpc
-
-#endif  // GRPC_INTERNAL_CPP_COMMON_INSECURE_AUTH_CONTEXT_H

src/cpp/common/insecure_create_auth_context.cc

@@ -34,13 +34,12 @@
 
 #include <grpc/grpc.h>
 #include <grpc++/auth_context.h>
-#include "src/cpp/common/insecure_auth_context.h"
 
 namespace grpc {
 
-std::unique_ptr<const AuthContext> CreateAuthContext(grpc_call* call) {
+std::shared_ptr<const AuthContext> CreateAuthContext(grpc_call* call) {
   (void)call;
-  return std::unique_ptr<const AuthContext>(new InsecureAuthContext);
+  return std::shared_ptr<const AuthContext>();
 }
 
 }  // namespace grpc

src/cpp/common/secure_auth_context.h

@@ -39,7 +39,7 @@
 
 namespace grpc {
 
-class SecureAuthContext : public AuthContext {
+class SecureAuthContext GRPC_FINAL : public AuthContext {
  public:
   SecureAuthContext(grpc_auth_context* ctx);
 

src/cpp/common/secure_create_auth_context.cc

@@ -39,12 +39,13 @@
 
 namespace grpc {
 
-std::unique_ptr<const AuthContext> CreateAuthContext(grpc_call* call) {
-  grpc_auth_context* context = nullptr;
-  if (call) {
-    context = const_cast<grpc_auth_context*>(grpc_call_auth_context(call));
+std::shared_ptr<const AuthContext> CreateAuthContext(grpc_call* call) {
+  if (call == nullptr) {
+    return std::shared_ptr<const AuthContext>();
   }
-  return std::unique_ptr<const AuthContext>(new SecureAuthContext(context));
+  grpc_auth_context* context =
+      const_cast<grpc_auth_context*>(grpc_call_auth_context(call));
+  return std::shared_ptr<const AuthContext>(new SecureAuthContext(context));
 }
 
 }  // namespace grpc

src/cpp/server/server.cc

@@ -118,7 +118,7 @@ class Server::SyncRequest GRPC_FINAL : public CompletionQueueTag {
           has_request_payload_(mrd->has_request_payload_),
           request_payload_(mrd->request_payload_),
           method_(mrd->method_) {
-      ctx_.call_ = mrd->call_;
+      ctx_.set_call(mrd->call_);
       ctx_.cq_ = &cq_;
       GPR_ASSERT(mrd->in_flight_);
       mrd->in_flight_ = false;
@@ -325,7 +325,7 @@ bool Server::BaseAsyncRequest::FinalizeResult(void** tag, bool* status) {
     }
   }
   grpc_metadata_array_destroy(&initial_metadata_array_);
-  context_->call_ = call_;
+  context_->set_call(call_);
   context_->cq_ = call_cq_;
   Call call(call_, server_, call_cq_, server_->max_message_size_);
   if (*status && call_) {

src/cpp/server/server_context.cc

@@ -148,8 +148,9 @@ bool ServerContext::IsCancelled() {
   return completion_op_ && completion_op_->CheckCancelled(cq_);
 }
 
-std::unique_ptr<const AuthContext> ServerContext::auth_context() const {
-  return CreateAuthContext(call_);
+void ServerContext::set_call(grpc_call* call) {
+  call_ = call;
+  auth_context_ = CreateAuthContext(call);
 }
 
 }  // namespace grpc

test/cpp/end2end/end2end_test.cc

@@ -85,7 +85,7 @@ void MaybeEchoDeadline(ServerContext* context, const EchoRequest* request,
 
 template <typename T>
 void CheckAuthContext(T* context) {
-  std::unique_ptr<const AuthContext> auth_ctx = context->auth_context();
+  std::shared_ptr<const AuthContext> auth_ctx = context->auth_context();
   std::vector<grpc::string> fake =
       auth_ctx->FindPropertyValues("transport_security_type");
   EXPECT_EQ(1, fake.size());

tools/run_tests/sources_and_headers.json

@@ -9666,7 +9666,6 @@
       "include/grpc++/time.h", 
       "src/cpp/client/channel.h", 
       "src/cpp/common/create_auth_context.h", 
-      "src/cpp/common/insecure_auth_context.h", 
       "src/cpp/server/thread_pool.h"
     ], 
     "language": "c++", 
@@ -9722,7 +9721,6 @@
       "src/cpp/common/call.cc", 
       "src/cpp/common/completion_queue.cc", 
       "src/cpp/common/create_auth_context.h", 
-      "src/cpp/common/insecure_auth_context.h", 
       "src/cpp/common/insecure_create_auth_context.cc", 
       "src/cpp/common/rpc_method.cc", 
       "src/cpp/proto/proto_utils.cc", 

vsprojects/grpc++_unsecure/grpc++_unsecure.vcxproj

@@ -186,7 +186,6 @@
     <ClInclude Include="..\..\include\grpc++\time.h" />
   </ItemGroup>
   <ItemGroup>
-    <ClInclude Include="..\..\src\cpp\common\insecure_auth_context.h" />
     <ClInclude Include="..\..\src\cpp\client\channel.h" />
     <ClInclude Include="..\..\src\cpp\common\create_auth_context.h" />
     <ClInclude Include="..\..\src\cpp\server\thread_pool.h" />

vsprojects/grpc++_unsecure/grpc++_unsecure.vcxproj.filters

@@ -194,9 +194,6 @@
     </ClInclude>
   </ItemGroup>
   <ItemGroup>
-    <ClInclude Include="..\..\src\cpp\common\insecure_auth_context.h">
-      <Filter>src\cpp\common</Filter>
-    </ClInclude>
     <ClInclude Include="..\..\src\cpp\client\channel.h">
       <Filter>src\cpp\client</Filter>
     </ClInclude>