diff --git a/bazel/experiments.bzl b/bazel/experiments.bzl index 6e430d2d960..efcf8ecf73c 100644 --- a/bazel/experiments.bzl +++ b/bazel/experiments.bzl @@ -18,12 +18,6 @@ EXPERIMENTS = { "dbg": { - "core_end2end_tests": [ - "new_hpack_huffman_decoder", - ], - "hpack_test": [ - "new_hpack_huffman_decoder", - ], }, "off": { "core_end2end_test": [ @@ -51,6 +45,9 @@ EXPERIMENTS = { ], }, "on": { + "core_end2end_tests": [ + "new_hpack_huffman_decoder", + ], "endpoint_test": [ "tcp_read_chunks", ], @@ -61,6 +58,9 @@ EXPERIMENTS = { "flow_control_fixes", "tcp_read_chunks", ], + "hpack_test": [ + "new_hpack_huffman_decoder", + ], }, "opt": { }, diff --git a/src/core/lib/experiments/experiments.cc b/src/core/lib/experiments/experiments.cc index f9359aa9996..8e22592253d 100644 --- a/src/core/lib/experiments/experiments.cc +++ b/src/core/lib/experiments/experiments.cc @@ -53,11 +53,6 @@ const char* const description_posix_event_engine_enable_polling = "If set, enables polling on the default posix event engine."; const char* const description_free_large_allocator = "If set, return all free bytes from a \042big\042 allocator"; -#ifdef NDEBUG -const bool kDefaultForDebugOnly = false; -#else -const bool kDefaultForDebugOnly = true; -#endif } // namespace namespace grpc_core { @@ -72,8 +67,7 @@ const ExperimentMetadata g_experiment_metadata[] = { false}, {"unconstrained_max_quota_buffer_size", description_unconstrained_max_quota_buffer_size, false}, - {"new_hpack_huffman_decoder", description_new_hpack_huffman_decoder, - kDefaultForDebugOnly}, + {"new_hpack_huffman_decoder", description_new_hpack_huffman_decoder, true}, {"event_engine_client", description_event_engine_client, false}, {"monitoring_experiment", description_monitoring_experiment, true}, {"promise_based_client_call", description_promise_based_client_call, false}, diff --git a/src/core/lib/experiments/experiments.yaml b/src/core/lib/experiments/experiments.yaml index 6f67b9faa36..543d5a89d08 100644 --- a/src/core/lib/experiments/experiments.yaml +++ b/src/core/lib/experiments/experiments.yaml @@ -94,8 +94,8 @@ - name: new_hpack_huffman_decoder description: New HPACK huffman decoder - should be much faster than the existing implementation. - default: debug - expiry: 2023/01/01 + default: true + expiry: 2023/03/01 owner: ctiller@google.com test_tags: ["core_end2end_tests", "hpack_test"] - name: event_engine_client