From 82c01e5a9509adfa4fc4f81edd2cc6f16906e862 Mon Sep 17 00:00:00 2001 From: siddharthshukla Date: Tue, 23 Aug 2016 00:03:21 +0200 Subject: [PATCH] remove skipIf from TypeSmokeTest (issue 7672) remove skipIfStatement from TypeSmokeTest.testCallCredentialsFromPluginUpDown since the test passes on PyPy variants 5.3.0 and newer since these variants have improved compatibility support for the C-Extensions --- src/python/grpcio_tests/tests/unit/_cython/cygrpc_test.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/python/grpcio_tests/tests/unit/_cython/cygrpc_test.py b/src/python/grpcio_tests/tests/unit/_cython/cygrpc_test.py index 2f50263730f..142387d810a 100644 --- a/src/python/grpcio_tests/tests/unit/_cython/cygrpc_test.py +++ b/src/python/grpcio_tests/tests/unit/_cython/cygrpc_test.py @@ -114,9 +114,6 @@ class TypeSmokeTest(unittest.TestCase): lambda ignored_a, ignored_b: None, b'') del plugin - @unittest.skipIf( - platform.python_implementation() == "PyPy", - 'TODO(issue 7672): figure out why this fails on PyPy') def testCallCredentialsFromPluginUpDown(self): plugin = cygrpc.CredentialsMetadataPlugin(_metadata_plugin_callback, b'') call_credentials = cygrpc.call_credentials_metadata_plugin(plugin)