Merge pull request #22000 from yashykt/unusedparams

Remove some unused parameter warnings
pull/22016/head
Yash Tibrewal 5 years ago committed by GitHub
commit 820ee53030
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      include/grpcpp/impl/codegen/completion_queue_impl.h
  2. 3
      src/core/lib/iomgr/tcp_posix.cc
  3. 7
      src/core/lib/security/security_connector/local/local_security_connector.cc
  4. 2
      src/core/tsi/alts/handshaker/alts_handshaker_client.cc
  5. 2
      src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc

@ -387,12 +387,14 @@ class CompletionQueue : private ::grpc::GrpcLibraryCodegen {
}
void RegisterServer(const Server* server) {
(void)server;
#ifndef NDEBUG
grpc::internal::MutexLock l(&server_list_mutex_);
server_list_.push_back(server);
#endif
}
void UnregisterServer(const Server* server) {
(void)server;
#ifndef NDEBUG
grpc::internal::MutexLock l(&server_list_mutex_);
server_list_.remove(server);

@ -1385,7 +1385,8 @@ static bool do_tcp_flush_zerocopy(grpc_tcp* tcp, TcpZerocopySendRecord* record,
static void UnrefMaybePutZerocopySendRecord(grpc_tcp* tcp,
TcpZerocopySendRecord* record,
uint32_t seq, const char* tag) {
uint32_t seq,
const char* /* tag */) {
if (record->Unref()) {
tcp->tcp_zerocopy_send_ctx.PutSendRecord(record);
}

@ -66,8 +66,7 @@ grpc_core::RefCountedPtr<grpc_auth_context> local_auth_context_create(
return ctx;
}
void local_check_peer(grpc_security_connector* sc, tsi_peer peer,
grpc_endpoint* ep,
void local_check_peer(tsi_peer peer, grpc_endpoint* ep,
grpc_core::RefCountedPtr<grpc_auth_context>* auth_context,
grpc_closure* on_peer_checked,
grpc_local_connect_type type) {
@ -178,7 +177,7 @@ class grpc_local_channel_security_connector final
grpc_closure* on_peer_checked) override {
grpc_local_credentials* creds =
reinterpret_cast<grpc_local_credentials*>(mutable_channel_creds());
local_check_peer(this, peer, ep, auth_context, on_peer_checked,
local_check_peer(peer, ep, auth_context, on_peer_checked,
creds->connect_type());
}
@ -227,7 +226,7 @@ class grpc_local_server_security_connector final
grpc_closure* on_peer_checked) override {
grpc_local_server_credentials* creds =
static_cast<grpc_local_server_credentials*>(mutable_server_creds());
local_check_peer(this, peer, ep, auth_context, on_peer_checked,
local_check_peer(peer, ep, auth_context, on_peer_checked,
creds->connect_type());
}

@ -637,7 +637,7 @@ static void handshaker_client_shutdown(alts_handshaker_client* c) {
}
}
static void handshaker_call_unref(void* arg, grpc_error* error) {
static void handshaker_call_unref(void* arg, grpc_error* /* error */) {
grpc_call* call = static_cast<grpc_call*>(arg);
grpc_call_unref(call);
}

@ -430,7 +430,7 @@ struct alts_tsi_handshaker_continue_handshaker_next_args {
};
static void alts_tsi_handshaker_create_channel(void* arg,
grpc_error* unused_error) {
grpc_error* /* unused_error */) {
alts_tsi_handshaker_continue_handshaker_next_args* next_args =
static_cast<alts_tsi_handshaker_continue_handshaker_next_args*>(arg);
alts_tsi_handshaker* handshaker = next_args->handshaker;

Loading…
Cancel
Save