From 81b8f4179f6111b902cbed9eb65ef6f41eb1e32d Mon Sep 17 00:00:00 2001 From: tanvi-jagtap Date: Wed, 22 May 2024 10:04:30 +0000 Subject: [PATCH] [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log --- test/cpp/interop/xds_interop_server_lib.cc | 3 +-- test/cpp/qps/parse_json.cc | 4 ++-- test/cpp/qps/server_async.cc | 6 ++---- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/test/cpp/interop/xds_interop_server_lib.cc b/test/cpp/interop/xds_interop_server_lib.cc index c65e4198be5..d1ee23381af 100644 --- a/test/cpp/interop/xds_interop_server_lib.cc +++ b/test/cpp/interop/xds_interop_server_lib.cc @@ -201,8 +201,7 @@ absl::optional GetStatusForRpcBehaviorMetadata( } if (part != hostname) { VLOG(2) << "RPC behavior for a different host: \"" << std::string(part) - << "\", this one is: \"" < < < - hostname < "\""; + << "\", this one is: \"" << hostname << "\""; return absl::nullopt; } } else if (absl::ConsumePrefix(&part, kErrorCodeRpcBehavior)) { diff --git a/test/cpp/qps/parse_json.cc b/test/cpp/qps/parse_json.cc index 41e00f47d38..e283c8eae7d 100644 --- a/test/cpp/qps/parse_json.cc +++ b/test/cpp/qps/parse_json.cc @@ -39,8 +39,8 @@ void ParseJson(const std::string& json, const std::string& type, type_resolver.get(), "type.googleapis.com/" + type, json, &binary); if (!status.ok()) { std::string errmsg(status.message()); - LOG(ERROR) << "Failed to convert json to binary: errcode=" - << static_cast(status.code()) << " msg=" << errmsg; + LOG(ERROR) << "Failed to convert json to binary: errcode=" << status.code() + << " msg=" << errmsg; grpc_core::Crash(absl::StrFormat("JSON: %s", json.c_str())); } CHECK(msg->ParseFromString(binary)); diff --git a/test/cpp/qps/server_async.cc b/test/cpp/qps/server_async.cc index 96a1403fd07..16bb01e8960 100644 --- a/test/cpp/qps/server_async.cc +++ b/test/cpp/qps/server_async.cc @@ -93,10 +93,8 @@ class AsyncQpsServerTest final : public grpc::testing::Server { if (num_threads <= 0) { // dynamic sizing num_threads = std::min(64, cores()); LOG(INFO) << "Sizing async server to " << num_threads - << " threads. Defaults to number of cores " - "in machine or 64 threads if machine has more than 64 cores " - "to " - "avoid OOMs."; + << " threads. Defaults to number of cores in machine or 64 " + "threads if machine has more than 64 cores to avoid OOMs."; } int tpc = std::max(1, config.threads_per_cq()); // 1 if unspecified