Document plan to merge the GRPCChannel subclasses

pull/2754/head
Jorge Canizales 9 years ago
parent 77723b127a
commit 7e90745b3c
  1. 2
      src/objective-c/GRPCClient/private/GRPCSecureChannel.m
  2. 2
      src/objective-c/GRPCClient/private/GRPCUnsecuredChannel.m

@ -102,6 +102,8 @@ static grpc_credentials *CertificatesAtPath(NSString *path, NSError **errorPtr)
[super initWithChannel:grpc_secure_channel_create(credentials, host.UTF8String, args)]); [super initWithChannel:grpc_secure_channel_create(credentials, host.UTF8String, args)]);
} }
// TODO(jcanizales): GRPCSecureChannel and GRPCUnsecuredChannel are just convenience initializers
// for GRPCChannel. Move them into GRPCChannel, which will make the following unnecessary.
- (instancetype)initWithChannel:(grpc_channel *)unmanagedChannel { - (instancetype)initWithChannel:(grpc_channel *)unmanagedChannel {
[NSException raise:NSInternalInconsistencyException format:@"use another initializer"]; [NSException raise:NSInternalInconsistencyException format:@"use another initializer"];
return [self initWithHost:nil]; // silence warnings return [self initWithHost:nil]; // silence warnings

@ -41,6 +41,8 @@
return (self = [super initWithChannel:grpc_insecure_channel_create(host.UTF8String, NULL)]); return (self = [super initWithChannel:grpc_insecure_channel_create(host.UTF8String, NULL)]);
} }
// TODO(jcanizales): GRPCSecureChannel and GRPCUnsecuredChannel are just convenience initializers
// for GRPCChannel. Move them into GRPCChannel, which will make the following unnecessary.
- (instancetype)initWithChannel:(grpc_channel *)unmanagedChannel { - (instancetype)initWithChannel:(grpc_channel *)unmanagedChannel {
[NSException raise:NSInternalInconsistencyException format:@"use the other initializer"]; [NSException raise:NSInternalInconsistencyException format:@"use the other initializer"];
return [self initWithHost:nil]; // silence warnings return [self initWithHost:nil]; // silence warnings

Loading…
Cancel
Save