Clean up the TODO item in build target `grpc_base` -- part `closure` (#31001)

* Clean up the TODO item in build target `grpc_base` part `closure`

* Update

* Update

* Revert "Update"

This reverts commit daf3118390.

* Update

* Update

* Automated change: Fix sanity tests
pull/31709/head
Cheng-Yu Chung 2 years ago committed by GitHub
parent 7e736c7a6b
commit 7e3ada34e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 11
      BUILD
  2. 17
      src/core/BUILD
  3. 1
      src/core/ext/transport/cronet/BUILD
  4. 1
      test/core/channel/BUILD
  5. 1
      test/core/client_channel/resolvers/BUILD
  6. 3
      test/core/end2end/BUILD
  7. 1
      test/core/end2end/fuzzers/BUILD
  8. 1
      test/core/filters/BUILD
  9. 1
      test/core/handshake/BUILD
  10. 1
      test/core/http/BUILD
  11. 2
      test/core/surface/BUILD
  12. 3
      test/core/transport/chttp2/BUILD
  13. 3
      test/core/util/BUILD
  14. 2
      test/cpp/common/BUILD
  15. 6
      test/cpp/microbenchmarks/BUILD

11
BUILD

@ -1342,7 +1342,6 @@ grpc_cc_library(
# re-export these headers from here for now, and when LSC's have completed
# to clean this up, we'll remove these.
[
"//src/core:lib/iomgr/closure.h",
"//src/core:lib/channel/channel_args.h",
],
external_deps = [
@ -1766,6 +1765,7 @@ grpc_cc_library(
"//src/core:channel_fwd",
"//src/core:channel_init",
"//src/core:channel_stack_type",
"//src/core:closure",
"//src/core:default_event_engine",
"//src/core:env",
"//src/core:error",
@ -1827,6 +1827,7 @@ grpc_cc_library(
"ref_counted_ptr",
"//src/core:arena",
"//src/core:channel_init",
"//src/core:closure",
"//src/core:error",
"//src/core:gpr_atm",
"//src/core:gpr_manual_constructor",
@ -2135,6 +2136,7 @@ grpc_cc_library(
"grpc_base",
"//src/core:arena",
"//src/core:channel_stack_type",
"//src/core:closure",
"//src/core:slice",
"//src/core:slice_buffer",
"//src/core:slice_refcount",
@ -2692,6 +2694,7 @@ grpc_cc_library(
"//src/core:channel_fwd",
"//src/core:channel_init",
"//src/core:channel_stack_type",
"//src/core:closure",
"//src/core:construct_destruct",
"//src/core:dual_ref_counted",
"//src/core:env",
@ -2773,6 +2776,7 @@ grpc_cc_library(
"server_address",
"sockaddr_utils",
"uri_parser",
"//src/core:closure",
"//src/core:error",
"//src/core:event_engine_common",
"//src/core:grpc_resolver_dns_selection",
@ -2828,6 +2832,7 @@ grpc_cc_library(
"sockaddr_utils",
"uri_parser",
"//src/core:channel_args_preconditioning",
"//src/core:closure",
"//src/core:error",
"//src/core:handshaker_registry",
"//src/core:iomgr_fwd",
@ -2873,6 +2878,7 @@ grpc_cc_library(
"tsi_alts_credentials",
"tsi_base",
"//src/core:arena_promise",
"//src/core:closure",
"//src/core:error",
"//src/core:iomgr_fwd",
"//src/core:slice",
@ -2939,6 +2945,7 @@ grpc_cc_library(
"ref_counted_ptr",
"uri_parser",
"//src/core:arena_promise",
"//src/core:closure",
"//src/core:error",
"//src/core:gpr_manual_constructor",
"//src/core:httpcli_ssl_credentials",
@ -3038,6 +3045,7 @@ grpc_cc_library(
"grpc_base",
"tsi_base",
"//src/core:arena",
"//src/core:closure",
"//src/core:error",
"//src/core:pollset_set",
"//src/core:slice",
@ -3510,6 +3518,7 @@ grpc_cc_library(
"//src/core:bdp_estimator",
"//src/core:bitset",
"//src/core:chttp2_flow_control",
"//src/core:closure",
"//src/core:error",
"//src/core:gpr_atm",
"//src/core:http2_errors",

@ -1145,6 +1145,7 @@ grpc_cc_library(
hdrs = [
"lib/iomgr/closure.h",
],
visibility = ["@grpc:alt_grpc_base_legacy"],
deps = [
"error",
"gpr_manual_constructor",
@ -2479,6 +2480,7 @@ grpc_cc_library(
language = "c++",
deps = [
"arena_promise",
"closure",
"error",
"iomgr_fwd",
"slice",
@ -2514,6 +2516,7 @@ grpc_cc_library(
language = "c++",
deps = [
"arena_promise",
"closure",
"error",
"iomgr_fwd",
"tsi_local_credentials",
@ -2566,6 +2569,7 @@ grpc_cc_library(
language = "c++",
deps = [
"arena_promise",
"closure",
"error",
"grpc_sockaddr",
"iomgr_fwd",
@ -2607,6 +2611,7 @@ grpc_cc_library(
language = "c++",
deps = [
"arena_promise",
"closure",
"error",
"iomgr_fwd",
"unique_type_name",
@ -2644,6 +2649,7 @@ grpc_cc_library(
language = "c++",
tags = ["nofixdeps"],
deps = [
"closure",
"env",
"error",
"grpc_external_account_credentials",
@ -2718,6 +2724,7 @@ grpc_cc_library(
language = "c++",
deps = [
"arena_promise",
"closure",
"error",
"iomgr_fwd",
"ref_counted",
@ -2792,6 +2799,7 @@ grpc_cc_library(
deps = [
"activity",
"arena_promise",
"closure",
"context",
"error",
"httpcli_ssl_credentials",
@ -2845,6 +2853,7 @@ grpc_cc_library(
],
language = "c++",
deps = [
"closure",
"env",
"error",
"grpc_oauth2_credentials",
@ -2881,6 +2890,7 @@ grpc_cc_library(
language = "c++",
deps = [
"arena_promise",
"closure",
"error",
"iomgr_fwd",
"unique_type_name",
@ -3308,6 +3318,7 @@ grpc_cc_library(
"channel_fwd",
"channel_init",
"channel_stack_type",
"closure",
"error",
"gpr_atm",
"grpc_sockaddr",
@ -3381,6 +3392,7 @@ grpc_cc_library(
],
language = "c++",
deps = [
"closure",
"dual_ref_counted",
"error",
"grpc_fake_credentials",
@ -3498,6 +3510,7 @@ grpc_cc_library(
"certificate_provider_registry",
"channel_creds_registry",
"channel_fwd",
"closure",
"default_event_engine",
"env",
"envoy_admin_upb",
@ -4475,6 +4488,7 @@ grpc_cc_library(
],
language = "c++",
deps = [
"closure",
"env",
"error",
"grpc_xds_client",
@ -4621,6 +4635,7 @@ grpc_cc_library(
deps = [
"channel_args_preconditioning",
"channel_stack_type",
"closure",
"error",
"grpc_insecure_credentials",
"handshaker_registry",
@ -4666,6 +4681,7 @@ grpc_cc_library(
],
language = "c++",
deps = [
"closure",
"error",
"grpc_insecure_credentials",
"handshaker_registry",
@ -4716,6 +4732,7 @@ grpc_cc_library(
"arena",
"channel_args_preconditioning",
"channel_stack_type",
"closure",
"error",
"iomgr_fwd",
"slice",

@ -49,5 +49,6 @@ grpc_cc_library(
deps = [
"//:grpc_base",
"//:grpc_transport_chttp2",
"//src/core:closure",
],
)

@ -57,6 +57,7 @@ grpc_cc_test(
"//:channel_stack_builder",
"//:gpr",
"//:grpc",
"//src/core:closure",
"//test/core/util:grpc_test_util",
],
)

@ -53,6 +53,7 @@ grpc_cc_test(
deps = [
"//:gpr",
"//:grpc",
"//src/core:closure",
"//test/core/util:grpc_test_util",
],
)

@ -70,6 +70,7 @@ grpc_cc_library(
"//:httpcli",
"//:sockaddr_utils",
"//src/core:channel_args_preconditioning",
"//src/core:closure",
"//src/core:error",
"//src/core:iomgr_fwd",
"//src/core:pollset_set",
@ -118,6 +119,7 @@ grpc_cc_test(
"//:gpr",
"//:grpc",
"//:grpc_public_hdrs",
"//src/core:closure",
"//src/core:error",
"//src/core:gpr_atm",
"//src/core:iomgr_fwd",
@ -182,6 +184,7 @@ grpc_cc_test(
"//:grpc_public_hdrs",
"//:grpc_resolver_dns_ares",
"//:server_address",
"//src/core:closure",
"//src/core:default_event_engine",
"//src/core:error",
"//src/core:grpc_sockaddr",

@ -38,6 +38,7 @@ grpc_proto_fuzzer(
deps = [
"//:gpr",
"//:grpc",
"//src/core:closure",
"//src/core:slice",
"//test/core/end2end:ssl_test_data",
"//test/core/event_engine/fuzzing_event_engine",

@ -58,6 +58,7 @@ grpc_proto_fuzzer(
deps = [
"//:gpr",
"//:grpc",
"//src/core:closure",
"//test/core/end2end:ssl_test_data",
"//test/core/util:grpc_test_util",
],

@ -82,6 +82,7 @@ grpc_cc_test(
":server_ssl_common",
"//:gpr",
"//:grpc",
"//src/core:closure",
"//test/core/util:grpc_test_util",
],
)

@ -114,6 +114,7 @@ grpc_cc_test(
":httpcli_test_util",
"//:gpr",
"//:grpc",
"//src/core:closure",
"//test/core/end2end:ssl_test_data",
"//test/core/util:fake_udp_and_tcp_server",
"//test/core/util:grpc_test_util",

@ -64,6 +64,7 @@ grpc_cc_test(
deps = [
"//:gpr",
"//:grpc",
"//src/core:closure",
"//test/core/util:grpc_test_util",
],
)
@ -93,6 +94,7 @@ grpc_cc_test(
deps = [
"//:gpr",
"//:grpc",
"//src/core:closure",
"//test/core/end2end:cq_verifier",
"//test/core/util:grpc_test_util",
],

@ -163,6 +163,7 @@ grpc_cc_test(
deps = [
"//:gpr",
"//:grpc",
"//src/core:closure",
"//src/core:slice",
"//test/core/end2end:cq_verifier",
"//test/core/util:grpc_test_util",
@ -239,6 +240,7 @@ grpc_cc_test(
"//:channel_stack_builder",
"//:gpr",
"//:grpc",
"//src/core:closure",
"//src/core:slice",
"//test/core/end2end:cq_verifier",
"//test/core/util:grpc_test_util",
@ -256,6 +258,7 @@ grpc_cc_test(
deps = [
"//:gpr",
"//:grpc",
"//src/core:closure",
"//test/core/util:grpc_test_util",
"//test/core/util:grpc_test_util_base",
],

@ -95,6 +95,7 @@ grpc_cc_library(
"//:iomgr_timer",
"//:ref_counted_ptr",
"//src/core:arena",
"//src/core:closure",
"//src/core:grpc_authorization_base",
"//src/core:grpc_sockaddr",
"//src/core:iomgr_fwd",
@ -136,6 +137,7 @@ grpc_cc_library(
"//:tsi_ssl_credentials",
"//:uri_parser",
"//src/core:channel_args_preconditioning",
"//src/core:closure",
"//src/core:error",
"//src/core:gpr_atm",
"//src/core:grpc_sockaddr",
@ -175,6 +177,7 @@ grpc_cc_library(
"//:ref_counted_ptr",
"//:uri_parser",
"//src/core:channel_args_preconditioning",
"//src/core:closure",
"//src/core:error",
"//src/core:gpr_atm",
"//src/core:grpc_sockaddr",

@ -41,6 +41,7 @@ grpc_cc_test(
flaky = True,
deps = [
"//:grpc++",
"//src/core:closure",
"//test/core/util:grpc_test_util",
],
)
@ -61,6 +62,7 @@ grpc_cc_test(
],
deps = [
"//:grpc++",
"//src/core:closure",
"//test/core/util:grpc_test_util",
],
)

@ -137,7 +137,10 @@ grpc_cc_test(
"no_mac",
"no_windows",
],
deps = [":helpers"],
deps = [
":helpers",
"//src/core:closure",
],
)
grpc_cc_test(
@ -340,6 +343,7 @@ grpc_cc_test(
],
deps = [
":helpers",
"//src/core:closure",
"//src/core:slice",
],
)

Loading…
Cancel
Save