mirror of https://github.com/grpc/grpc.git
[EventEngine] Change TXT lookup result type to std::vector<std::string> (#33030)
One TXT lookup query can return multiple TXT records (see the following example). `EventEngine::DNSResolver` should return all of them to let the caller (e.g. `event_engine_client_channel_resolver`) decide which one they would use. ``` $ dig TXT wikipedia.org ; <<>> DiG 9.18.12-1+build1-Debian <<>> TXT wikipedia.org ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 49626 ;; flags: qr rd ra; QUERY: 1, ANSWER: 3, AUTHORITY: 0, ADDITIONAL: 1 ;; OPT PSEUDOSECTION: ; EDNS: version: 0, flags:; udp: 512 ;; QUESTION SECTION: ;wikipedia.org. IN TXT ;; ANSWER SECTION: wikipedia.org. 600 IN TXT "google-site-verification=AMHkgs-4ViEvIJf5znZle-BSE2EPNFqM1nDJGRyn2qk" wikipedia.org. 600 IN TXT "yandex-verification: 35c08d23099dc863" wikipedia.org. 600 IN TXT "v=spf1 include:wikimedia.org ~all" ``` Note that this change also deviates us from the iomgr's DNSResolver API which uses std::string as the result type. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->pull/33041/head
parent
56938bcc6b
commit
7df0e11755
3 changed files with 21 additions and 6 deletions
Loading…
Reference in new issue