Reviewer comments

pull/17757/head
Yash Tibrewal 6 years ago
parent 944b3114fe
commit 789870a00b
  1. 2
      src/core/lib/gprpp/optional.h
  2. 2
      src/core/lib/iomgr/buffer_list.h

@ -36,6 +36,8 @@ class Optional {
void reset() { set_ = false; } void reset() { set_ = false; }
T value() { return value_; } T value() { return value_; }
private:
T value_; T value_;
bool set_ = false; bool set_ = false;
}; };

@ -36,7 +36,7 @@ struct ConnectionMetrics {
/* Delivery rate in Bytes/s. */ /* Delivery rate in Bytes/s. */
Optional<uint64_t> delivery_rate; Optional<uint64_t> delivery_rate;
/* If the delivery rate is limited by the application, this is set to true. */ /* If the delivery rate is limited by the application, this is set to true. */
Optional<uint64_t> is_delivery_rate_app_limited; Optional<bool> is_delivery_rate_app_limited;
/* Total packets retransmitted. */ /* Total packets retransmitted. */
Optional<uint32_t> packet_retx; Optional<uint32_t> packet_retx;
/* Total packets retransmitted spuriously. This metric is smaller than or /* Total packets retransmitted spuriously. This metric is smaller than or

Loading…
Cancel
Save