From 776b2210c6fbb0211a17a3a78de12ba5b525d6ca Mon Sep 17 00:00:00 2001 From: Yijie Ma Date: Tue, 17 Oct 2023 14:21:35 -0700 Subject: [PATCH] [Bazel] Fix some build deps (#34662) Fixes https://github.com/grpc/grpc/issues/34482. But this is only a bandaid, there is a bigger issue with build dependencies. AFAICT, https://github.com/grpc/grpc/blob/master/tools/distrib/fix_build_deps.py does not work on many targets, e.g. if the target has specified the `nofixdeps` tag or if a field is set to a variable, e.g. ``` GRPCXX_SRCS = [ "a", "b", "c", ] ... srcs = GRPCXX_SRCS, ``` --- BUILD | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BUILD b/BUILD index 3ee434b96f6..9be5d55d0a0 100644 --- a/BUILD +++ b/BUILD @@ -1110,6 +1110,7 @@ grpc_cc_library( "//src/core:default_event_engine", "//src/core:iomgr_fwd", "//src/core:iomgr_port", + "//src/core:notification", "//src/core:slice", "//src/core:slice_refcount", "//src/core:status_helper", @@ -1842,6 +1843,7 @@ grpc_cc_library( visibility = ["@grpc:tsi_interface"], deps = [ "gpr", + "grpc_public_hdrs", "grpc_trace", ], ) @@ -2761,6 +2763,7 @@ grpc_cc_library( external_deps = [ "absl/strings", "absl/strings:str_format", + "absl/types:optional", ], tags = ["nofixdeps"], visibility = ["@grpc:iomgr_buffer_list"], @@ -3672,6 +3675,7 @@ grpc_cc_library( deps = [ "backoff", "debug_location", + "endpoint_addresses", "envoy_admin_upb", "envoy_config_core_upb", "envoy_config_endpoint_upb",