Guarantee that Z_FINISH is only applied at the end of stream

7 years ago · 76e0c1ddd5
parent c353643c37
commit 76e0c1ddd5
1 changed files with 2 additions and 1 deletions
--- a/src/core/ext/transport/chttp2/transport/writing.c
+++ b/src/core/ext/transport/chttp2/transport/writing.c
@ -322,7 +322,8 @@ grpc_chttp2_begin_write_result grpc_chttp2_begin_write(
                    (send_bytes == s->compressed_data_buffer->length &&
                     s->flow_controlled_buffer.length == 0 &&
                     s->fetching_send_message == NULL);
-                if (is_last_data_frame && s->stream_compression_ctx != NULL) {
+                if (is_last_data_frame && s->send_trailing_metadata != NULL &&
+                    s->stream_compression_ctx != NULL) {
                  if (!grpc_stream_compress(
                          s->stream_compression_ctx, &s->flow_controlled_buffer,
                          s->compressed_data_buffer, NULL, MAX_SIZE_T,