From 740d219435d12a393327e0f8a9f2673b941465ae Mon Sep 17 00:00:00 2001 From: Ajinkya Kulkarni Date: Fri, 8 Nov 2024 11:02:10 -0800 Subject: [PATCH] [PHP] Fix flaky MacOS tests (#38090) This fixes b/323916594. In some flaky cases, a skipped test seems to be causing an unnecessary segfault at the test shutdown. This test is no longer relevant in newer version of PHP. It had been skipped for a while already. Closes #38090 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/38090 from ajinkyakulkarni75:skipped-test 2d159b4ffb8de40837c33b6117edfe7619eb30db PiperOrigin-RevId: 694567089 --- src/php/tests/unit_tests/TimevalTest.php | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/php/tests/unit_tests/TimevalTest.php b/src/php/tests/unit_tests/TimevalTest.php index cc8e40d00ac..ee944896fc2 100644 --- a/src/php/tests/unit_tests/TimevalTest.php +++ b/src/php/tests/unit_tests/TimevalTest.php @@ -64,18 +64,6 @@ class TimevalTest extends \PHPUnit\Framework\TestCase $this->assertSame('Grpc\Timeval', get_class($this->time)); } - public function testConstructorWithFloat() - { - if (version_compare(PHP_VERSION, '8.1.0') >= 0) { - $this->markTestSkipped('implicit float to int cast deprecated in 8.1+'); - } - $this->time = new Grpc\Timeval(123.456); - $this->assertNotNull($this->time); - $this->assertSame('Grpc\Timeval', get_class($this->time)); - $timeFromInt = new Grpc\Timeval(123); - $this->assertSame(0, Grpc\Timeval::compare($this->time, $timeFromInt)); - } - public function testConstructorWithBigInt() { $this->time = new Grpc\Timeval(7200000000); // > 2^32