mirror of https://github.com/grpc/grpc.git
[PSM Interop] Fix the 10-minute-teardown issue in GAMMA tests (#34560)
We shouldn't just set `termination_grace_period_seconds=600` by default for all gamma tests extending `GammaXdsKubernetesTestCase`. This is what's causing the deployment deletion issue: > `framework.helpers.retryers.RetryError: Retry error calling framework.xds_k8s_testcase.IsolatedXdsKubernetesTestCase.cleanup: 1 attempts exhausted. Last exception: RetryError: Retry error calling framework.infrastructure.k8s.KubernetesNamespace.get_deployment: timeout 0:05:00 (h:mm:ss) exceeded. Check result callback returned False.` We wait for 5 minutes, while the deployment is happily handing for 10. Then the second cleanup retry kills it - but not before waiting for another 5 minutes. I think `self.force = False` may be solving another issue triggered by the get_deployment retry timeout: because we start over deleting the resources by name and some of them are deleted from the first attempt we get 404. And I'm pretty sure we don't do error-handling correctly when deleting CRD-based resources - which cascades into even more unnecessary retries.pull/34593/head
parent
96f36b6991
commit
724e12a1c7
3 changed files with 8 additions and 6 deletions
Loading…
Reference in new issue