clang tidy

6 years ago · 71ecf17eb7
parent f7c8e8be62
commit 71ecf17eb7
2 changed files with 4 additions and 3 deletions
--- a/src/core/ext/filters/client_channel/lb_policy/xds/xds.cc
+++ b/src/core/ext/filters/client_channel/lb_policy/xds/xds.cc
@ -364,7 +364,7 @@ class XdsLb : public LoadBalancingPolicy {

      void UpdateLocked(
          xds_grpclb_serverlist* serverlist,
-          RefCountedPtr<ParsedLoadBalancingConfig> child_policy_config,
+          const RefCountedPtr<ParsedLoadBalancingConfig>& child_policy_config,
          const grpc_channel_args* args);
      void ShutdownLocked();
      void ResetBackoffLocked();
@ -412,7 +412,7 @@ class XdsLb : public LoadBalancingPolicy {

    void UpdateLocked(
        const LocalityList& locality_list,
-        RefCountedPtr<ParsedLoadBalancingConfig> child_policy_config,
+        const RefCountedPtr<ParsedLoadBalancingConfig>& child_policy_config,
        const grpc_channel_args* args, XdsLb* parent);
    void ShutdownLocked();
    void ResetBackoffLocked();
--- a/src/core/lib/gprpp/optional.h
+++ b/src/core/lib/gprpp/optional.h
@ -26,6 +26,7 @@ namespace grpc_core {
 template <typename T>
 class Optional {
 public:
+  Optional() { value_ = {}; }
  void set(const T& val) {
    value_ = val;
    set_ = true;
@ -39,7 +40,7 @@ class Optional {

 private:
  bool set_ = false;
-  T value_ = {};
+  T value_;
 };

 } /* namespace grpc_core */