Reviewer comments

src/core/lib/iomgr/logical_thread.cc

@@ -91,13 +91,11 @@ void LogicalThread::DrainQueue() {
         gpr_log(GPR_INFO, "  Queue returned nullptr, trying again");
       }
     }
-#ifndef NDEBUG
     if (GRPC_TRACE_FLAG_ENABLED(grpc_logical_thread_trace)) {
-      gpr_log(GPR_INFO,
-              "	 Running item %p : callback scheduled at [%s:%d]", cb_wrapper,
-              cb_wrapper->location.file(), cb_wrapper->location.line());
+      gpr_log(GPR_INFO, "  Running item %p : callback scheduled at [%s:%d]",
+              cb_wrapper, cb_wrapper->location.file(),
+              cb_wrapper->location.line());
     }
-#endif
     cb_wrapper->callback();
     delete cb_wrapper;
   }

test/core/iomgr/logical_thread_test.cc

@@ -43,17 +43,6 @@ TEST(LogicalThreadTest, ExecuteOne) {
               nullptr);
 }
 
-struct ThreadArgs {
-  size_t counter;
-  grpc_core::RefCountedPtr<grpc_core::LogicalThread> lock;
-  gpr_event done;
-};
-
-struct ExecutionArgs {
-  size_t* counter;
-  size_t value;
-};
-
 class TestThread {
  public:
   explicit TestThread(grpc_core::RefCountedPtr<grpc_core::LogicalThread> lock)
@@ -75,6 +64,10 @@ class TestThread {
     size_t n = 1;
     for (size_t i = 0; i < 10; i++) {
       for (size_t j = 0; j < 10000; j++) {
+        struct ExecutionArgs {
+          size_t* counter;
+          size_t value;
+        };
         ExecutionArgs* c = new ExecutionArgs;
         c->counter = &self->counter_;
         c->value = n++;