From 5fccd9019f01ea71db058c59e07c791556b5a22b Mon Sep 17 00:00:00 2001 From: murgatroid99 Date: Mon, 19 Oct 2015 10:58:10 -0700 Subject: [PATCH] This is a library. It should not output logs to STDOUT by default --- src/node/src/metadata.js | 1 - src/node/src/server.js | 4 ---- src/node/test/async_test.js | 1 - src/node/test/credentials_test.js | 2 +- 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/node/src/metadata.js b/src/node/src/metadata.js index 5c24e46c9b2..183c3ad4fcf 100644 --- a/src/node/src/metadata.js +++ b/src/node/src/metadata.js @@ -59,7 +59,6 @@ function normalizeKey(key) { function validate(key, value) { if (_.endsWith(key, '-bin')) { if (!(value instanceof Buffer)) { - console.log(value.constructor.toString()); throw new Error('keys that end with \'-bin\' must have Buffer values'); } } else { diff --git a/src/node/src/server.js b/src/node/src/server.js index a974d593c95..89e1090c6c4 100644 --- a/src/node/src/server.js +++ b/src/node/src/server.js @@ -597,10 +597,6 @@ function Server(options) { throw new Error('Server is already running'); } this.started = true; - console.log('Server starting'); - _.each(handlers, function(handler, handler_name) { - console.log('Serving', handler_name); - }); server.start(); /** * Handles the SERVER_RPC_NEW event. If there is a handler associated with diff --git a/src/node/test/async_test.js b/src/node/test/async_test.js index 6d71ea24f54..0af63c379e1 100644 --- a/src/node/test/async_test.js +++ b/src/node/test/async_test.js @@ -86,7 +86,6 @@ describe('Async functionality', function() { }); readStream.on('error', function (error) { - console.log(error); }); }); diff --git a/src/node/test/credentials_test.js b/src/node/test/credentials_test.js index 3d0b38fd52d..3e01b62cf49 100644 --- a/src/node/test/credentials_test.js +++ b/src/node/test/credentials_test.js @@ -71,7 +71,7 @@ var fakeSuccessfulGoogleCredentials = { var fakeFailingGoogleCredentials = { getRequestMetadata: function(service_url, callback) { setTimeout(function() { - callback(new Error("Authorization failure")); + callback(new Error('Authorization failure')); }, 0); } };