remove PromiseBasedLoadBalancedCall dtor -- already handled via OnCancel()

pull/35196/head
Mark D. Roth 1 year ago
parent 3943169a73
commit 6f2158b432
  1. 11
      src/core/ext/filters/client_channel/client_channel.cc
  2. 2
      src/core/ext/filters/client_channel/client_channel.h

@ -3487,17 +3487,6 @@ ClientChannel::PromiseBasedLoadBalancedCall::PromiseBasedLoadBalancedCall(
: LoadBalancedCall(chand, GetContext<grpc_call_context_element>(),
std::move(on_commit), is_transparent_retry) {}
ClientChannel::PromiseBasedLoadBalancedCall::~PromiseBasedLoadBalancedCall() {
if (was_queued_ && client_initial_metadata_ != nullptr) {
MutexLock lock(&chand()->lb_mu_);
Commit();
// Remove pick from list of queued picks.
RemoveCallFromLbQueuedCallsLocked();
// Remove from queued picks list.
chand()->lb_queued_calls_.erase(this);
}
}
ArenaPromise<ServerMetadataHandle>
ClientChannel::PromiseBasedLoadBalancedCall::MakeCallPromise(
CallArgs call_args, OrphanablePtr<PromiseBasedLoadBalancedCall> lb_call) {

@ -611,8 +611,6 @@ class ClientChannel::PromiseBasedLoadBalancedCall
absl::AnyInvocable<void()> on_commit,
bool is_transparent_retry);
~PromiseBasedLoadBalancedCall() override;
ArenaPromise<ServerMetadataHandle> MakeCallPromise(
CallArgs call_args, OrphanablePtr<PromiseBasedLoadBalancedCall> lb_call);

Loading…
Cancel
Save