From 6eddf397e93717986d008c23aadf5a200f23a33f Mon Sep 17 00:00:00 2001 From: Richard Belleville Date: Tue, 11 Feb 2020 17:44:56 -0800 Subject: [PATCH] Reviewer advice --- .pylintrc | 2 +- src/python/grpcio/grpc/_simple_stubs.py | 4 ---- src/python/grpcio/grpc/experimental/__init__.py | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.pylintrc b/.pylintrc index 97f9bc90c3d..be8be6b6ef0 100644 --- a/.pylintrc +++ b/.pylintrc @@ -19,7 +19,7 @@ dummy-variables-rgx=^ignored_|^unused_|_ # NOTE(nathaniel): Not particularly attached to this value; it just seems to # be what works for us at the moment (excepting the dead-code-walking Beta # API). -max-args=7 +max-args=14 max-parents=8 [MISCELLANEOUS] diff --git a/src/python/grpcio/grpc/_simple_stubs.py b/src/python/grpcio/grpc/_simple_stubs.py index 378c234cd15..72872e163c7 100644 --- a/src/python/grpcio/grpc/_simple_stubs.py +++ b/src/python/grpcio/grpc/_simple_stubs.py @@ -169,7 +169,6 @@ class ChannelCache: # Make this the default option. -# pylint: disable=too-many-arguments @experimental_api def unary_unary( request: RequestType, @@ -241,7 +240,6 @@ def unary_unary( timeout=timeout) -# pylint: disable=too-many-arguments @experimental_api def unary_stream( request: RequestType, @@ -312,7 +310,6 @@ def unary_stream( timeout=timeout) -# pylint: disable=too-many-arguments @experimental_api def stream_unary( request_iterator: Iterator[RequestType], @@ -383,7 +380,6 @@ def stream_unary( timeout=timeout) -# pylint: disable=too-many-arguments @experimental_api def stream_stream( request_iterator: Iterator[RequestType], diff --git a/src/python/grpcio/grpc/experimental/__init__.py b/src/python/grpcio/grpc/experimental/__init__.py index 93ed0f64291..6364e36b631 100644 --- a/src/python/grpcio/grpc/experimental/__init__.py +++ b/src/python/grpcio/grpc/experimental/__init__.py @@ -82,7 +82,6 @@ __all__ = ( 'ChannelOptions', 'ExperimentalApiWarning', 'UsageError', - 'experimental_api', 'insecure_channel_credentials', )