[Gpr_To_Absl_Logging] Cleaning up allow list.

PiperOrigin-RevId: 664712989
pull/37528/head
Tanvi Jagtap 3 months ago committed by Copybara-Service
parent a22ea0beb6
commit 6ead511863
  1. 29
      tools/run_tests/sanity/banned_functions.py

@ -20,15 +20,8 @@
# Any new instance of a deprecated function being used in the code will be
# flagged by the script. If there is a new instance of a deprecated function in
# a Pull Request, then the Sanity tests will fail for the Pull Request.
# We are currently working on clearing out the usage of deprecated functions in
# the entire gRPC code base.
# While our cleaning is in progress we have a temporary allow list. The allow
# list has a list of files where clean up of deprecated functions is pending.
# As we clean up the deprecated function from files, we will remove them from
# the allow list.
# It would be wise to do the file clean up and the altering of the allow list
# in the same PR. This will make sure that any roll back of a clean up PR will
# also alter the allow list and avoid build failures.
# The allow list has a list of files where clean up of deprecated functions is
# pending.
import os
import sys
@ -76,13 +69,13 @@ DEPRECATED_FUNCTION_TEMP_ALLOW_LIST = {
"./src/core/util/posix/log.cc",
"./src/core/util/windows/log.cc",
],
"gpr_log_func_args": [],
"gpr_set_log_function(": [],
"GPR_ASSERT": [],
"gpr_assertion_failed": [],
"GPR_DEBUG_ASSERT": [],
"gpr_log_severity_string": [],
"gpr_set_log_verbosity(": [],
"gpr_log_func_args": [], # Safe to delete this entry after Nov 2024.
"gpr_set_log_function(": [], # Safe to delete this entry after Nov 2024.
"GPR_ASSERT": [], # Safe to delete this entry after Nov 2024.
"gpr_assertion_failed": [], # Safe to delete this entry after Nov 2024.
"GPR_DEBUG_ASSERT": [], # Safe to delete this entry after Nov 2024.
"gpr_log_severity_string": [], # Safe to delete this entry after Nov 2024.
"gpr_set_log_verbosity(": [], # Safe to delete this entry after Nov 2024.
}
errors = 0
@ -117,5 +110,5 @@ if errors > 0:
# https://github.com/grpc/grpc/issues/15381
# Basically, a change rendered this script useless and we did not realize it.
# This check ensures that this type of issue doesn't occur again.
assert num_files > 18000 # we have more files
# print(('Number of files checked : %d ' % (num_files)))
assert num_files > 18000
print("Number of files checked : %d " % (num_files))

Loading…
Cancel
Save