Addressing review comments

10 years ago · 6c2d56b7ef
parent 6999c096d8
commit 6c2d56b7ef
1 changed files with 2 additions and 1 deletions
--- a/src/core/transport/metadata.c
+++ b/src/core/transport/metadata.c
@ -318,6 +318,7 @@ grpc_mdstr *grpc_mdstr_from_string(grpc_mdctx *ctx, const char *str, int canonic
    for (i = 0; str[i]; i++) {
      if (str[i] >= 'A' && str[i] <= 'Z') {
        canonical = 0;
+        /* Keep going in loop just to get string length */
      }
    }
    len = i;
@ -325,7 +326,7 @@ grpc_mdstr *grpc_mdstr_from_string(grpc_mdctx *ctx, const char *str, int canonic
    if (canonical) {
      return grpc_mdstr_from_buffer(ctx, (const gpr_uint8 *)str, len);
    } else {
-      char *copy = gpr_malloc(len + 1);
+      char *copy = gpr_malloc(len);
      grpc_mdstr *ret;
      for (i = 0; i < len; i++) {
        if (str[i] >= 'A' && str[i] <= 'Z') {