Merge pull request #7959 from stanley-cheung/php-minor-fix-interop

PHP: use ssl hostname override as auth audience uri if present
pull/7925/merge
Stanley Cheung 9 years ago committed by GitHub
commit 6b69169e7c
  1. 11
      src/php/lib/Grpc/BaseStub.php
  2. 2
      src/php/tests/interop/interop_client.php

@ -41,6 +41,7 @@ namespace Grpc;
class BaseStub
{
private $hostname;
private $hostname_override;
private $channel;
// a callback function
@ -75,6 +76,9 @@ class BaseStub
} else {
$opts['grpc.primary_user_agent'] = '';
}
if (!empty($opts['grpc.ssl_target_name_override'])) {
$this->hostname_override = $opts['grpc.ssl_target_name_override'];
}
$opts['grpc.primary_user_agent'] .=
'grpc-php/'.$package_config['version'];
if (!array_key_exists('credentials', $opts)) {
@ -173,7 +177,12 @@ class BaseStub
}
$service_name = substr($method, 0, $last_slash_idx);
return 'https://'.$this->hostname.$service_name;
if ($this->hostname_override) {
$hostname = $this->hostname_override;
} else {
$hostname = $this->hostname;
}
return 'https://'.$hostname.$service_name;
}
/**

@ -108,7 +108,7 @@ function performLargeUnary($stub, $fillUsername = false, $fillOauthScope = false
$request->setFillUsername($fillUsername);
$request->setFillOauthScope($fillOauthScope);
$options = false;
$options = [];
if ($callback) {
$options['call_credentials_callback'] = $callback;
}

Loading…
Cancel
Save