From 6b45cea2f0fa10ab44d5446105df4dff8be2d656 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Thu, 7 Mar 2019 17:56:49 -0800 Subject: [PATCH] Remove from poll-cv comments too --- src/core/lib/iomgr/ev_poll_posix.cc | 2 +- test/core/end2end/tests/keepalive_timeout.cc | 3 +-- test/cpp/end2end/BUILD | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/core/lib/iomgr/ev_poll_posix.cc b/src/core/lib/iomgr/ev_poll_posix.cc index 4c98ffa9448..29111dd44ed 100644 --- a/src/core/lib/iomgr/ev_poll_posix.cc +++ b/src/core/lib/iomgr/ev_poll_posix.cc @@ -125,7 +125,7 @@ struct grpc_fd { grpc_fork_fd_list* fork_fd_list; }; -/* True when GRPC_ENABLE_FORK_SUPPORT=1. We do not support fork with poll-cv */ +/* True when GRPC_ENABLE_FORK_SUPPORT=1. */ static bool track_fds_for_fork = false; /* Only used when GRPC_ENABLE_FORK_SUPPORT=1 */ diff --git a/test/core/end2end/tests/keepalive_timeout.cc b/test/core/end2end/tests/keepalive_timeout.cc index 2c992848b95..3c33f0419ad 100644 --- a/test/core/end2end/tests/keepalive_timeout.cc +++ b/test/core/end2end/tests/keepalive_timeout.cc @@ -226,8 +226,7 @@ static void test_keepalive_timeout(grpc_end2end_test_config config) { * that the keepalive ping is never sent. */ static void test_read_delays_keepalive(grpc_end2end_test_config config) { char* poller = gpr_getenv("GRPC_POLL_STRATEGY"); - /* It is hard to get the timing right for the polling engines poll and poll-cv - */ + /* It is hard to get the timing right for the polling engine poll. */ if (poller != nullptr && (0 == strcmp(poller, "poll"))) { gpr_free(poller); return; diff --git a/test/cpp/end2end/BUILD b/test/cpp/end2end/BUILD index 43dee177e7a..26095a41607 100644 --- a/test/cpp/end2end/BUILD +++ b/test/cpp/end2end/BUILD @@ -242,7 +242,7 @@ grpc_cc_test( grpc_cc_test( name = "end2end_test", - size = "large", # with poll-cv this takes long, see #17493 + size = "large", deps = [ ":end2end_test_lib", ],