Chiebot-Mirror
/
grpc
mirror of https://github.com/grpc/grpc.git
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36547)

Browse Source 
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log

In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.

We have the following mapping
1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)

Reviewers need to check :
1. If the above mapping is correct.
2. The content of the log is as before.

gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.

Closes #36547

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36547 from tanvi-jagtap:test_cpp_ext_stats_plugin_tjagtap 8e80774fe1
PiperOrigin-RevId: 632020672
pull/36559/head^2
Tanvi Jagtap 7 months ago committed by Copybara-Service
parent e3be06ee38
commit 6b3a670cb0
2 changed files with 92 additions and 91 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 1
      test/cpp/ext/filters/census/BUILD
  2. 182
      test/cpp/ext/filters/census/stats_plugin_end2end_test.cc

1
test/cpp/ext/filters/census/BUILD
Unescape View File

@ -51,6 +51,7 @@ grpc_cc_test(
"stats_plugin_end2end_test.cc",
],
external_deps = [
"absl/log:log",
"gtest",
"opencensus-stats-test",
"opencensus-tags",

182
test/cpp/ext/filters/census/stats_plugin_end2end_test.cc
Unescape View File

@ -20,6 +20,7 @@
#include <thread> // NOLINT
#include <vector>
#include "absl/log/log.h"
#include "absl/strings/str_cat.h"
#include "absl/strings/string_view.h"
#include "gmock/gmock.h"
@ -517,8 +518,8 @@ TEST_F(StatsPluginEnd2EndTest, TestRetryStatsWithAdditionalRetries) {
::testing::ElementsAre(client_method_name_), ::testing::Eq(0))));
auto data = client_retry_delay_per_call_view.GetData().distribution_data();
for (const auto& entry : data) {
gpr_log(GPR_ERROR, "Mean Retry Delay %s: %lf ms", entry.first[0].c_str(),
entry.second.mean());
LOG(ERROR) << "Mean Retry Delay " << entry.first[0] << ": "
<< entry.second.mean() << " ms";
}
// We expect the retry delay to be around 100ms.
EXPECT_THAT(
@ -1007,95 +1008,94 @@ TEST_F(StatsPluginEnd2EndTest, TestGlobalEnableOpenCensusTracing) {
// This test verifies that users depending on src/cpp/ext/filters/census header
// files can continue using the non-experimental names.
TEST(StatsPluginDeclarationTest, Declarations) {
gpr_log(GPR_INFO, "%p", ClientMethodTagKey);
gpr_log(GPR_INFO, "%p", ClientStatusTagKey);
gpr_log(GPR_INFO, "%p", ServerMethodTagKey);
gpr_log(GPR_INFO, "%p", ServerStatusTagKey);
gpr_log(GPR_INFO, "%p", kRpcClientReceivedBytesPerRpcMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcClientReceivedMessagesPerRpcMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcClientRetriesPerCallMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcClientRetryDelayPerCallMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcClientRoundtripLatencyMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcClientSentBytesPerRpcMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcClientSentMessagesPerRpcMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcClientServerLatencyMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcClientStartedRpcsMeasureName.data());
gpr_log(GPR_INFO, "%p",
kRpcClientTransparentRetriesPerCallMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcServerReceivedBytesPerRpcMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcServerReceivedMessagesPerRpcMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcServerSentBytesPerRpcMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcServerSentMessagesPerRpcMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcServerServerLatencyMeasureName.data());
gpr_log(GPR_INFO, "%p", kRpcServerStartedRpcsMeasureName.data());
gpr_log(GPR_INFO, "%p", ClientCompletedRpcsCumulative);
gpr_log(GPR_INFO, "%p", ClientReceivedBytesPerRpcCumulative);
gpr_log(GPR_INFO, "%p", ClientReceivedMessagesPerRpcCumulative);
gpr_log(GPR_INFO, "%p", ClientRetriesCumulative);
gpr_log(GPR_INFO, "%p", ClientRetriesPerCallCumulative);
gpr_log(GPR_INFO, "%p", ClientRetryDelayPerCallCumulative);
gpr_log(GPR_INFO, "%p", ClientRoundtripLatencyCumulative);
gpr_log(GPR_INFO, "%p", ClientSentBytesPerRpcCumulative);
gpr_log(GPR_INFO, "%p", ClientSentMessagesPerRpcCumulative);
gpr_log(GPR_INFO, "%p", ClientServerLatencyCumulative);
gpr_log(GPR_INFO, "%p", ClientStartedRpcsCumulative);
gpr_log(GPR_INFO, "%p", ClientTransparentRetriesCumulative);
gpr_log(GPR_INFO, "%p", ClientTransparentRetriesPerCallCumulative);
gpr_log(GPR_INFO, "%p", ServerCompletedRpcsCumulative);
gpr_log(GPR_INFO, "%p", ServerReceivedBytesPerRpcCumulative);
gpr_log(GPR_INFO, "%p", ServerReceivedMessagesPerRpcCumulative);
gpr_log(GPR_INFO, "%p", ServerSentBytesPerRpcCumulative);
gpr_log(GPR_INFO, "%p", ServerSentMessagesPerRpcCumulative);
gpr_log(GPR_INFO, "%p", ServerServerLatencyCumulative);
gpr_log(GPR_INFO, "%p", ServerStartedRpcsCumulative);
gpr_log(GPR_INFO, "%p", ClientCompletedRpcsMinute);
gpr_log(GPR_INFO, "%p", ClientReceivedBytesPerRpcMinute);
gpr_log(GPR_INFO, "%p", ClientReceivedMessagesPerRpcMinute);
gpr_log(GPR_INFO, "%p", ClientRetriesMinute);
gpr_log(GPR_INFO, "%p", ClientRetriesPerCallMinute);
gpr_log(GPR_INFO, "%p", ClientRetryDelayPerCallMinute);
gpr_log(GPR_INFO, "%p", ClientRoundtripLatencyMinute);
gpr_log(GPR_INFO, "%p", ClientSentBytesPerRpcMinute);
gpr_log(GPR_INFO, "%p", ClientSentMessagesPerRpcMinute);
gpr_log(GPR_INFO, "%p", ClientServerLatencyMinute);
gpr_log(GPR_INFO, "%p", ClientStartedRpcsMinute);
gpr_log(GPR_INFO, "%p", ClientTransparentRetriesMinute);
gpr_log(GPR_INFO, "%p", ClientTransparentRetriesPerCallMinute);
gpr_log(GPR_INFO, "%p", ServerCompletedRpcsMinute);
gpr_log(GPR_INFO, "%p", ServerReceivedBytesPerRpcMinute);
gpr_log(GPR_INFO, "%p", ServerReceivedMessagesPerRpcMinute);
gpr_log(GPR_INFO, "%p", ServerSentBytesPerRpcMinute);
gpr_log(GPR_INFO, "%p", ServerSentMessagesPerRpcMinute);
gpr_log(GPR_INFO, "%p", ServerServerLatencyMinute);
gpr_log(GPR_INFO, "%p", ServerStartedRpcsMinute);
gpr_log(GPR_INFO, "%p", ClientCompletedRpcsHour);
gpr_log(GPR_INFO, "%p", ClientReceivedBytesPerRpcHour);
gpr_log(GPR_INFO, "%p", ClientReceivedMessagesPerRpcHour);
gpr_log(GPR_INFO, "%p", ClientRetriesHour);
gpr_log(GPR_INFO, "%p", ClientRetriesPerCallHour);
gpr_log(GPR_INFO, "%p", ClientRetryDelayPerCallHour);
gpr_log(GPR_INFO, "%p", ClientRoundtripLatencyHour);
gpr_log(GPR_INFO, "%p", ClientSentBytesPerRpcHour);
gpr_log(GPR_INFO, "%p", ClientSentMessagesPerRpcHour);
gpr_log(GPR_INFO, "%p", ClientServerLatencyHour);
gpr_log(GPR_INFO, "%p", ClientStartedRpcsHour);
gpr_log(GPR_INFO, "%p", ClientTransparentRetriesHour);
gpr_log(GPR_INFO, "%p", ClientTransparentRetriesPerCallHour);
gpr_log(GPR_INFO, "%p", ServerCompletedRpcsHour);
gpr_log(GPR_INFO, "%p", ServerReceivedBytesPerRpcHour);
gpr_log(GPR_INFO, "%p", ServerReceivedMessagesPerRpcHour);
gpr_log(GPR_INFO, "%p", ServerSentBytesPerRpcHour);
gpr_log(GPR_INFO, "%p", ServerSentMessagesPerRpcHour);
gpr_log(GPR_INFO, "%p", ServerServerLatencyHour);
gpr_log(GPR_INFO, "%p", ServerStartedRpcsHour);
LOG(INFO) << ClientMethodTagKey;
LOG(INFO) << ClientStatusTagKey;
LOG(INFO) << ServerMethodTagKey;
LOG(INFO) << ServerStatusTagKey;
LOG(INFO) << kRpcClientReceivedBytesPerRpcMeasureName.data();
LOG(INFO) << kRpcClientReceivedMessagesPerRpcMeasureName.data();
LOG(INFO) << kRpcClientRetriesPerCallMeasureName.data();
LOG(INFO) << kRpcClientRetryDelayPerCallMeasureName.data();
LOG(INFO) << kRpcClientRoundtripLatencyMeasureName.data();
LOG(INFO) << kRpcClientSentBytesPerRpcMeasureName.data();
LOG(INFO) << kRpcClientSentMessagesPerRpcMeasureName.data();
LOG(INFO) << kRpcClientServerLatencyMeasureName.data();
LOG(INFO) << kRpcClientStartedRpcsMeasureName.data();
LOG(INFO) << kRpcClientTransparentRetriesPerCallMeasureName.data();
LOG(INFO) << kRpcServerReceivedBytesPerRpcMeasureName.data();
LOG(INFO) << kRpcServerReceivedMessagesPerRpcMeasureName.data();
LOG(INFO) << kRpcServerSentBytesPerRpcMeasureName.data();
LOG(INFO) << kRpcServerSentMessagesPerRpcMeasureName.data();
LOG(INFO) << kRpcServerServerLatencyMeasureName.data();
LOG(INFO) << kRpcServerStartedRpcsMeasureName.data();
LOG(INFO) << ClientCompletedRpcsCumulative;
LOG(INFO) << ClientReceivedBytesPerRpcCumulative;
LOG(INFO) << ClientReceivedMessagesPerRpcCumulative;
LOG(INFO) << ClientRetriesCumulative;
LOG(INFO) << ClientRetriesPerCallCumulative;
LOG(INFO) << ClientRetryDelayPerCallCumulative;
LOG(INFO) << ClientRoundtripLatencyCumulative;
LOG(INFO) << ClientSentBytesPerRpcCumulative;
LOG(INFO) << ClientSentMessagesPerRpcCumulative;
LOG(INFO) << ClientServerLatencyCumulative;
LOG(INFO) << ClientStartedRpcsCumulative;
LOG(INFO) << ClientTransparentRetriesCumulative;
LOG(INFO) << ClientTransparentRetriesPerCallCumulative;
LOG(INFO) << ServerCompletedRpcsCumulative;
LOG(INFO) << ServerReceivedBytesPerRpcCumulative;
LOG(INFO) << ServerReceivedMessagesPerRpcCumulative;
LOG(INFO) << ServerSentBytesPerRpcCumulative;
LOG(INFO) << ServerSentMessagesPerRpcCumulative;
LOG(INFO) << ServerServerLatencyCumulative;
LOG(INFO) << ServerStartedRpcsCumulative;
LOG(INFO) << ClientCompletedRpcsMinute;
LOG(INFO) << ClientReceivedBytesPerRpcMinute;
LOG(INFO) << ClientReceivedMessagesPerRpcMinute;
LOG(INFO) << ClientRetriesMinute;
LOG(INFO) << ClientRetriesPerCallMinute;
LOG(INFO) << ClientRetryDelayPerCallMinute;
LOG(INFO) << ClientRoundtripLatencyMinute;
LOG(INFO) << ClientSentBytesPerRpcMinute;
LOG(INFO) << ClientSentMessagesPerRpcMinute;
LOG(INFO) << ClientServerLatencyMinute;
LOG(INFO) << ClientStartedRpcsMinute;
LOG(INFO) << ClientTransparentRetriesMinute;
LOG(INFO) << ClientTransparentRetriesPerCallMinute;
LOG(INFO) << ServerCompletedRpcsMinute;
LOG(INFO) << ServerReceivedBytesPerRpcMinute;
LOG(INFO) << ServerReceivedMessagesPerRpcMinute;
LOG(INFO) << ServerSentBytesPerRpcMinute;
LOG(INFO) << ServerSentMessagesPerRpcMinute;
LOG(INFO) << ServerServerLatencyMinute;
LOG(INFO) << ServerStartedRpcsMinute;
LOG(INFO) << ClientCompletedRpcsHour;
LOG(INFO) << ClientReceivedBytesPerRpcHour;
LOG(INFO) << ClientReceivedMessagesPerRpcHour;
LOG(INFO) << ClientRetriesHour;
LOG(INFO) << ClientRetriesPerCallHour;
LOG(INFO) << ClientRetryDelayPerCallHour;
LOG(INFO) << ClientRoundtripLatencyHour;
LOG(INFO) << ClientSentBytesPerRpcHour;
LOG(INFO) << ClientSentMessagesPerRpcHour;
LOG(INFO) << ClientServerLatencyHour;
LOG(INFO) << ClientStartedRpcsHour;
LOG(INFO) << ClientTransparentRetriesHour;
LOG(INFO) << ClientTransparentRetriesPerCallHour;
LOG(INFO) << ServerCompletedRpcsHour;
LOG(INFO) << ServerReceivedBytesPerRpcHour;
LOG(INFO) << ServerReceivedMessagesPerRpcHour;
LOG(INFO) << ServerSentBytesPerRpcHour;
LOG(INFO) << ServerSentMessagesPerRpcHour;
LOG(INFO) << ServerServerLatencyHour;
LOG(INFO) << ServerStartedRpcsHour;
}
} // namespace

Write Preview
Loading…
Cancel
Save