[chttp2] Fix comments and messages (#38071)

Fix https://github.com/grpc/grpc/issues/37859

Closes #38071

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/38071 from yashykt:FixMessage a16d5f13c0
PiperOrigin-RevId: 693813129
pull/37782/merge
Yash Tibrewal 3 weeks ago committed by Copybara-Service
parent d53dde77dc
commit 6a0377ea4c
  1. 14
      src/core/ext/transport/chttp2/client/chttp2_connector.cc

@ -248,8 +248,7 @@ class Chttp2SecureClientChannelFactory : public ClientChannelFactory {
ChannelArgs args) { ChannelArgs args) {
auto* channel_credentials = args.GetObject<grpc_channel_credentials>(); auto* channel_credentials = args.GetObject<grpc_channel_credentials>();
if (channel_credentials == nullptr) { if (channel_credentials == nullptr) {
return absl::InternalError( return absl::InternalError("channel credentials missing for channel");
"channel credentials missing for secure channel");
} }
// Make sure security connector does not already exist in args. // Make sure security connector does not already exist in args.
if (args.Contains(GRPC_ARG_SECURITY_CONNECTOR)) { if (args.Contains(GRPC_ARG_SECURITY_CONNECTOR)) {
@ -269,8 +268,7 @@ class Chttp2SecureClientChannelFactory : public ClientChannelFactory {
/*call_creds=*/nullptr, authority->c_str(), &args); /*call_creds=*/nullptr, authority->c_str(), &args);
if (subchannel_security_connector == nullptr) { if (subchannel_security_connector == nullptr) {
return absl::InternalError(absl::StrFormat( return absl::InternalError(absl::StrFormat(
"Failed to create secure subchannel for secure name '%s'", "Failed to create subchannel for secure name '%s'", *authority));
*authority));
} }
return args.SetObject(std::move(subchannel_security_connector)); return args.SetObject(std::move(subchannel_security_connector));
} }
@ -299,7 +297,7 @@ void FactoryInit() {
} // namespace } // namespace
// Create a secure client channel: // Create a client channel:
// Asynchronously: - resolve target // Asynchronously: - resolve target
// - connect to it (trying alternatives as presented) // - connect to it (trying alternatives as presented)
// - perform handshakes // - perform handshakes
@ -308,8 +306,8 @@ grpc_channel* grpc_channel_create(const char* target,
const grpc_channel_args* c_args) { const grpc_channel_args* c_args) {
grpc_core::ExecCtx exec_ctx; grpc_core::ExecCtx exec_ctx;
GRPC_TRACE_LOG(api, INFO) GRPC_TRACE_LOG(api, INFO)
<< "grpc_secure_channel_create(target=" << target << "grpc_channel_create(target=" << target << ", creds=" << (void*)creds
<< ", creds=" << (void*)creds << ", args=" << (void*)c_args << ")"; << ", args=" << (void*)c_args << ")";
grpc_channel* channel = nullptr; grpc_channel* channel = nullptr;
grpc_error_handle error; grpc_error_handle error;
if (creds != nullptr) { if (creds != nullptr) {
@ -338,7 +336,7 @@ grpc_channel* grpc_channel_create(const char* target,
status = static_cast<grpc_status_code>(integer); status = static_cast<grpc_status_code>(integer);
} }
channel = grpc_lame_client_channel_create( channel = grpc_lame_client_channel_create(
target, status, "Failed to create secure client channel"); target, status, "Failed to create client channel");
} }
return channel; return channel;
} }

Loading…
Cancel
Save