mirror of https://github.com/grpc/grpc.git
Merge pull request #13815 from vjpai/catcher
C++: Catch exceptions from sync method handlers rather than crashing serverpull/14023/head
Vijay Pai
7 years ago
committed by
GitHub
commit
69d3e0984d
13 changed files with 454 additions and 90 deletions
@ -0,0 +1,119 @@ |
||||
/*
|
||||
* |
||||
* Copyright 2017 gRPC authors. |
||||
* |
||||
* Licensed under the Apache License, Version 2.0 (the "License"); |
||||
* you may not use this file except in compliance with the License. |
||||
* You may obtain a copy of the License at |
||||
* |
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
* |
||||
* Unless required by applicable law or agreed to in writing, software |
||||
* distributed under the License is distributed on an "AS IS" BASIS, |
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||
* See the License for the specific language governing permissions and |
||||
* limitations under the License. |
||||
* |
||||
*/ |
||||
|
||||
#include <exception> |
||||
#include <memory> |
||||
|
||||
#include <grpc++/channel.h> |
||||
#include <grpc++/client_context.h> |
||||
#include <grpc++/server.h> |
||||
#include <grpc++/server_builder.h> |
||||
#include <grpc++/server_context.h> |
||||
#include <grpc/impl/codegen/port_platform.h> |
||||
|
||||
#include "src/proto/grpc/testing/echo.grpc.pb.h" |
||||
#include "test/core/util/test_config.h" |
||||
|
||||
#include <gtest/gtest.h> |
||||
|
||||
namespace grpc { |
||||
namespace testing { |
||||
|
||||
const char* kErrorMessage = "This service caused an exception"; |
||||
|
||||
#if GRPC_ALLOW_EXCEPTIONS |
||||
class ExceptingServiceImpl : public ::grpc::testing::EchoTestService::Service { |
||||
public: |
||||
Status Echo(ServerContext* server_context, const EchoRequest* request, |
||||
EchoResponse* response) override { |
||||
throw - 1; |
||||
} |
||||
Status RequestStream(ServerContext* context, |
||||
ServerReader<EchoRequest>* reader, |
||||
EchoResponse* response) override { |
||||
throw ServiceException(); |
||||
} |
||||
|
||||
private: |
||||
class ServiceException final : public std::exception { |
||||
public: |
||||
ServiceException() {} |
||||
|
||||
private: |
||||
const char* what() const noexcept override { return kErrorMessage; } |
||||
}; |
||||
}; |
||||
|
||||
class ExceptionTest : public ::testing::Test { |
||||
protected: |
||||
ExceptionTest() {} |
||||
|
||||
void SetUp() override { |
||||
ServerBuilder builder; |
||||
builder.RegisterService(&service_); |
||||
server_ = builder.BuildAndStart(); |
||||
} |
||||
|
||||
void TearDown() override { server_->Shutdown(); } |
||||
|
||||
void ResetStub() { |
||||
channel_ = server_->InProcessChannel(ChannelArguments()); |
||||
stub_ = grpc::testing::EchoTestService::NewStub(channel_); |
||||
} |
||||
|
||||
std::shared_ptr<Channel> channel_; |
||||
std::unique_ptr<grpc::testing::EchoTestService::Stub> stub_; |
||||
std::unique_ptr<Server> server_; |
||||
ExceptingServiceImpl service_; |
||||
}; |
||||
|
||||
TEST_F(ExceptionTest, Unary) { |
||||
ResetStub(); |
||||
EchoRequest request; |
||||
EchoResponse response; |
||||
request.set_message("test"); |
||||
ClientContext context; |
||||
|
||||
Status s = stub_->Echo(&context, request, &response); |
||||
EXPECT_FALSE(s.ok()); |
||||
EXPECT_EQ(s.error_code(), StatusCode::UNKNOWN); |
||||
} |
||||
|
||||
TEST_F(ExceptionTest, RequestStream) { |
||||
ResetStub(); |
||||
EchoResponse response; |
||||
ClientContext context; |
||||
|
||||
auto stream = stub_->RequestStream(&context, &response); |
||||
stream->WritesDone(); |
||||
Status s = stream->Finish(); |
||||
|
||||
EXPECT_FALSE(s.ok()); |
||||
EXPECT_EQ(s.error_code(), StatusCode::UNKNOWN); |
||||
} |
||||
|
||||
#endif // GRPC_ALLOW_EXCEPTIONS
|
||||
|
||||
} // namespace testing
|
||||
} // namespace grpc
|
||||
|
||||
int main(int argc, char** argv) { |
||||
grpc_test_init(argc, argv); |
||||
::testing::InitGoogleTest(&argc, argv); |
||||
return RUN_ALL_TESTS(); |
||||
} |
||||
Loading…
Reference in new issue