Merge pull request #4637 from murgatroid99/core_metadata_validation_empty_check

Make metadata validation functions reject empty keys
9 years ago · 6924aaa517
parent 6b4066c131 58bb40fe74
commit 6924aaa517
1 changed files with 3 additions and 0 deletions
--- a/src/core/surface/validate_metadata.c
+++ b/src/core/surface/validate_metadata.c
@ -53,6 +53,9 @@ int grpc_header_key_is_legal(const char *key, size_t length) {
      0x00, 0x00, 0x00, 0x00, 0x00, 0x20, 0xff, 0x03, 0x00, 0x00, 0x00,
      0x80, 0xfe, 0xff, 0xff, 0x07, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
+  if (length == 0) {
+    return 0;
+  }
  return conforms_to(key, length, legal_header_bits);
 }