Avoid linter warnings

reviewable/pr21361/r10
Yash Tibrewal 5 years ago
parent ee08000f41
commit 68ac18b095
  1. 2
      src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_ev_driver_posix.cc
  2. 3
      src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_ev_driver_windows.cc
  3. 3
      test/core/client_channel/resolvers/dns_resolver_connectivity_test.cc
  4. 3
      test/core/end2end/fuzzers/api_fuzzer.cc

@ -98,7 +98,7 @@ class GrpcPolledFdFactoryPosix : public GrpcPolledFdFactory {
}; };
std::unique_ptr<GrpcPolledFdFactory> NewGrpcPolledFdFactory( std::unique_ptr<GrpcPolledFdFactory> NewGrpcPolledFdFactory(
std::shared_ptr<WorkSerializer> /*work_serializer*/) { std::shared_ptr<WorkSerializer> work_serializer) { /* NOLINT */
return MakeUnique<GrpcPolledFdFactoryPosix>(); return MakeUnique<GrpcPolledFdFactoryPosix>();
} }

@ -577,7 +577,8 @@ class GrpcPolledFdWindows {
GrpcPolledFdWindows* polled_fd = static_cast<GrpcPolledFdWindows*>(arg); GrpcPolledFdWindows* polled_fd = static_cast<GrpcPolledFdWindows*>(arg);
GRPC_ERROR_REF(error); // ref owned by lambda GRPC_ERROR_REF(error); // ref owned by lambda
polled_fd->work_serializer_->Run( polled_fd->work_serializer_->Run(
[polled_fd, error]() { OnIocpReadableLocked(error); }, DEBUG_LOCATION); [polled_fd, error]() { polled_fd->OnIocpReadableLocked(error); },
DEBUG_LOCATION);
} }
// TODO(apolcyn): improve this error handling to be less conversative. // TODO(apolcyn): improve this error handling to be less conversative.

@ -66,7 +66,8 @@ static grpc_ares_request* my_dns_lookup_ares_locked(
std::unique_ptr<grpc_core::ServerAddressList>* addresses, std::unique_ptr<grpc_core::ServerAddressList>* addresses,
bool /*check_grpclb*/, char** /*service_config_json*/, bool /*check_grpclb*/, char** /*service_config_json*/,
int /*query_timeout_ms*/, int /*query_timeout_ms*/,
std::shared_ptr<grpc_core::WorkSerializer> /*work_serializer*/) { std::shared_ptr<
grpc_core::WorkSerializer> /* work_serializer */) { /* NOLINT */
gpr_mu_lock(&g_mu); gpr_mu_lock(&g_mu);
GPR_ASSERT(0 == strcmp("test", addr)); GPR_ASSERT(0 == strcmp("test", addr));
grpc_error* error = GRPC_ERROR_NONE; grpc_error* error = GRPC_ERROR_NONE;

@ -380,7 +380,8 @@ grpc_ares_request* my_dns_lookup_ares_locked(
std::unique_ptr<grpc_core::ServerAddressList>* addresses, std::unique_ptr<grpc_core::ServerAddressList>* addresses,
bool /*check_grpclb*/, char** /*service_config_json*/, bool /*check_grpclb*/, char** /*service_config_json*/,
int /*query_timeout*/, int /*query_timeout*/,
std::shared_ptr<grpc_core::WorkSerializer> /*work_serializer*/) { std::shared_ptr<
grpc_core::WorkSerializer> /* work_serializer */) { /* NOLINT */
addr_req* r = static_cast<addr_req*>(gpr_malloc(sizeof(*r))); addr_req* r = static_cast<addr_req*>(gpr_malloc(sizeof(*r)));
r->addr = gpr_strdup(addr); r->addr = gpr_strdup(addr);
r->on_done = on_done; r->on_done = on_done;

Loading…
Cancel
Save