Single-parameter constructors should be marked explicit.

10 years ago · 68095aab7d
parent 04a1bebeb0
commit 68095aab7d
1 changed files with 1 additions and 1 deletions
--- a/cpp/helloworld/greeter_async_client.cc
+++ b/cpp/helloworld/greeter_async_client.cc
@ -59,7 +59,7 @@ using helloworld::Greeter;

 class GreeterClient {
 public:
-  GreeterClient(std::shared_ptr<ChannelInterface> channel)
+  explicit GreeterClient(std::shared_ptr<ChannelInterface> channel)
      : stub_(Greeter::NewStub(channel)) {}

  std::string SayHello(const std::string& user) {