From 666ea7cd219a96e0e15332ed097ffda44855feea Mon Sep 17 00:00:00 2001 From: Sergii Tkachenko Date: Tue, 23 Aug 2022 15:16:30 -0700 Subject: [PATCH] xDS interop: fix an issue with secondary zone namespaces not cleaned (#30717) All alternative server runners except the failover test reuse the primary server runners' namespace. Failover test is using the secondary cluster, and manages its own namespace there. `reuse_namespace` disables namespace cleanup, and in this case it was set to `True` incorrectly. --- tools/run_tests/xds_k8s_test_driver/tests/failover_test.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/run_tests/xds_k8s_test_driver/tests/failover_test.py b/tools/run_tests/xds_k8s_test_driver/tests/failover_test.py index a34bb61170d..7691b3cd286 100644 --- a/tools/run_tests/xds_k8s_test_driver/tests/failover_test.py +++ b/tools/run_tests/xds_k8s_test_driver/tests/failover_test.py @@ -60,7 +60,9 @@ class FailoverTest(xds_k8s_testcase.RegularXdsKubernetesTestCase): xds_server_uri=self.xds_server_uri, network=self.network, debug_use_port_forwarding=self.debug_use_port_forwarding, - reuse_namespace=True) + # This runner's namespace created in the secondary cluster, + # so it's not reused and must be cleaned up. + reuse_namespace=False) def cleanup(self): super().cleanup()