From 664ba4fac47f58d280a56ddd9b8e7f04b7c673c5 Mon Sep 17 00:00:00 2001 From: ncteisen Date: Wed, 11 Jul 2018 08:42:12 -0700 Subject: [PATCH] Add note about on-by-default --- src/core/lib/surface/channel.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/core/lib/surface/channel.cc b/src/core/lib/surface/channel.cc index 3e4e434a63b..8f3ad6c1915 100644 --- a/src/core/lib/surface/channel.cc +++ b/src/core/lib/surface/channel.cc @@ -148,6 +148,8 @@ grpc_channel* grpc_channel_create_with_builder( channel_tracer_max_nodes = (size_t)grpc_channel_arg_get_integer(&args->args[i], options); } else if (0 == strcmp(args->args[i].key, GRPC_ARG_ENABLE_CHANNELZ)) { + // channelz will not be enabled by default until all concerns in + // https://github.com/grpc/grpc/issues/15986 are addressed. channelz_enabled = grpc_channel_arg_get_bool(&args->args[i], false); } else if (0 == strcmp(args->args[i].key, GRPC_ARG_CHANNELZ_CHANNEL_NODE_CREATION_FUNC)) {