[codegen] Prohibit the "debug" configuration in experiment codegen

tools/codegen/core/experiments_compiler.py

@@ -261,16 +261,17 @@ class ExperimentDefinition(object):
             )
             self._error = True
             return False
-        is_dict = isinstance(rollout_attributes["default"], dict)
         for platform in allowed_platforms:
-            if is_dict:
+            if isinstance(rollout_attributes["default"], dict):
                 value = rollout_attributes["default"].get(platform, False)
-            else:
-                value = rollout_attributes["default"]
                 if isinstance(value, dict):
+                    # debug is assumed for all rollouts with additional constraints
                     self._default[platform] = "debug"
                     self._additional_constraints[platform] = value
-            elif value not in allowed_defaults:
+                    continue
+            else:
+                value = rollout_attributes["default"]
+            if value not in allowed_defaults:
                 print(
                     "ERROR: default for experiment %s on platform %s "
                     "is of incorrect format"
@@ -278,7 +279,6 @@ class ExperimentDefinition(object):
                 )
                 self._error = True
                 return False
-            else:
             self._default[platform] = value
             self._additional_constraints[platform] = {}
         return True
@@ -637,6 +637,14 @@ class ExperimentsCompiler(object):
                 s.add(req)
         return s
 
+    def EnsureNoDebugExperiments(self):
+        for name, exp in self._experiment_definitions.items():
+            for platform, default in exp._default.items():
+                if default == "debug":
+                    raise ValueError(
+                        f"Debug experiments are prohibited. '{name}' is configured with {exp._default}"
+                    )
+
     def GenExperimentsBzl(self, mode, output_file):
         assert self._FinalizeExperiments()
         if self._bzl_list_for_defaults is None:

tools/codegen/core/gen_experiments.py

@@ -87,6 +87,12 @@ def ParseCommandLineArguments(args):
         action="store_false",
         help="If specified, disables checking experiment expiry dates",
     )
+    flag_parser.add_argument(
+        "--no_dbg_experiments",
+        action="store_true",
+        help="Prohibit 'debug' configurations",
+        default=False,
+    )
     return flag_parser.parse_args(args)
 
 
@@ -162,6 +168,10 @@ def _GenerateExperimentFiles(args, mode):
             print("ERROR adding rollout spec")
             sys.exit(1)
 
+    if mode != "test" and args.no_dbg_experiments:
+        print("Ensuring no debug experiments are configured")
+        compiler.EnsureNoDebugExperiments()
+
     print(f"Mode = {mode} Generating experiments headers")
     compiler.GenerateExperimentsHdr(_EXPERIMENTS_HDR_FILE, mode)
 

tools/distrib/gen_experiments_and_format.sh

@@ -15,7 +15,7 @@
 
 set -e
 cd $(dirname $0)/../..
-tools/codegen/core/gen_experiments.py --check
+tools/codegen/core/gen_experiments.py --check --no_dbg_experiments
 # clang format
 TEST='' \
     CHANGED_FILES="$(git status --porcelain | awk '{print $2}' | tr '\n' ' ')" \