Reviewer feedback

pull/13413/head
ncteisen 7 years ago
parent 11f6780bfd
commit 6193c63dab
  1. 3
      include/grpc++/impl/codegen/call.h
  2. 2
      include/grpc++/impl/codegen/client_context.h
  3. 2
      test/cpp/end2end/end2end_test.cc

@ -595,8 +595,7 @@ class CallOpClientRecvStatus {
GRPC_SLICE_END_PTR(error_message_)),
binary_error_details);
client_context_->set_debug_error_string(
debug_error_string_ != nullptr ? grpc::string(debug_error_string_)
: "");
debug_error_string_ != nullptr ? debug_error_string_ : "");
g_core_codegen_interface->grpc_slice_unref(error_message_);
if (debug_error_string_ != nullptr) {
g_core_codegen_interface->gpr_free((void*)debug_error_string_);

@ -382,7 +382,7 @@ class ClientContext {
friend class ::grpc::internal::BlockingUnaryCallImpl;
// Used by friend class CallOpClientRecvStatus
void set_debug_error_string(grpc::string debug_error_string) {
void set_debug_error_string(const grpc::string& debug_error_string) {
debug_error_string_ = debug_error_string;
}

@ -741,7 +741,7 @@ TEST_P(End2endTest, RequestStreamOneRequest) {
Status s = stream->Finish();
EXPECT_EQ(response.message(), request.message());
EXPECT_TRUE(s.ok());
EXPECT_TRUE(context.debug_error_string() == "");
EXPECT_TRUE(context.debug_error_string().empty());
}
TEST_P(End2endTest, RequestStreamOneRequestWithCoalescingApi) {

Loading…
Cancel
Save