From f34e8e9c582b4d07e32d4d45c311547611c3006b Mon Sep 17 00:00:00 2001 From: ncteisen Date: Wed, 30 May 2018 12:15:19 -0700 Subject: [PATCH 1/2] Make combiner tracer debug only --- src/core/lib/iomgr/combiner.cc | 2 +- src/core/lib/iomgr/combiner.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/lib/iomgr/combiner.cc b/src/core/lib/iomgr/combiner.cc index 6789e4d12db..7c0062eb4ec 100644 --- a/src/core/lib/iomgr/combiner.cc +++ b/src/core/lib/iomgr/combiner.cc @@ -31,7 +31,7 @@ #include "src/core/lib/iomgr/executor.h" #include "src/core/lib/profiling/timers.h" -grpc_core::TraceFlag grpc_combiner_trace(false, "combiner"); +grpc_core::DebugOnlyTraceFlag grpc_combiner_trace(false, "combiner"); #define GRPC_COMBINER_TRACE(fn) \ do { \ diff --git a/src/core/lib/iomgr/combiner.h b/src/core/lib/iomgr/combiner.h index 0d63e468dfb..3c947bf9d64 100644 --- a/src/core/lib/iomgr/combiner.h +++ b/src/core/lib/iomgr/combiner.h @@ -61,6 +61,6 @@ grpc_closure_scheduler* grpc_combiner_finally_scheduler(grpc_combiner* lock); bool grpc_combiner_continue_exec_ctx(); -extern grpc_core::TraceFlag grpc_combiner_trace; +extern grpc_core::DebugOnlyTraceFlag grpc_combiner_trace; #endif /* GRPC_CORE_LIB_IOMGR_COMBINER_H */ From 5e6b75c1866ff298953813c2562fe359c071d7eb Mon Sep 17 00:00:00 2001 From: ncteisen Date: Wed, 30 May 2018 12:17:44 -0700 Subject: [PATCH 2/2] Update tracer docs --- doc/environment_variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/environment_variables.md b/doc/environment_variables.md index 15752ae865b..80b8ad8412b 100644 --- a/doc/environment_variables.md +++ b/doc/environment_variables.md @@ -44,7 +44,6 @@ some configuration as environment variables that can be set. - channel - traces operations on the C core channel stack - client_channel - traces client channel activity, including resolver and load balancing policy interaction - - combiner - traces combiner lock state - compression - traces compression operations - connectivity_state - traces connectivity state changes to channels - executor - traces grpc's internal thread pool ('the executor') @@ -80,6 +79,7 @@ some configuration as environment variables that can be set. accomplished by invoking `CONFIG=dbg make ` - alarm_refcount - refcounting traces for grpc_alarm structure - metadata - tracks creation and mutation of metadata + - combiner - traces combiner lock state - closure - tracks closure creation, scheduling, and completion - pending_tags - traces still-in-progress tags on completion queues - polling - traces the selected polling engine