From 612c743f54f15731f0fcb1295c02629877000ee2 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Wed, 26 Feb 2020 20:12:27 -0800 Subject: [PATCH] Remove the flakiness of disappearing_server end2end test. Fix #21221 --- test/core/end2end/tests/disappearing_server.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/core/end2end/tests/disappearing_server.cc b/test/core/end2end/tests/disappearing_server.cc index 0858ce39597..1380b5c362b 100644 --- a/test/core/end2end/tests/disappearing_server.cc +++ b/test/core/end2end/tests/disappearing_server.cc @@ -161,6 +161,14 @@ static void do_request_and_shutdown_server(grpc_end2end_test_config /*config*/, CQ_EXPECT_COMPLETION(cqv, tag(1), 1); CQ_EXPECT_COMPLETION(cqv, tag(1000), 1); cq_verify(cqv); + /* Please refer https://github.com/grpc/grpc/issues/21221 for additional + * details. + * TODO(yashykt@) - The following line should be removeable after C-Core + * correctly handles GOAWAY frames. Internal Reference b/135458602. If this + * test remains flaky even after this, an alternative fix would be to send a + * request when the server is in the shut down state. + */ + cq_verify_empty(cqv); GPR_ASSERT(status == GRPC_STATUS_UNIMPLEMENTED); GPR_ASSERT(0 == grpc_slice_str_cmp(details, "xyz"));