From 5ff8df71d48b7bb447dff2e98aa32a7f52640f12 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Fri, 26 Apr 2019 13:41:30 -0700 Subject: [PATCH] Add default constructor back to optional --- .../ext/filters/client_channel/resolver_result_parsing.cc | 6 +++--- src/core/lib/gprpp/optional.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/core/ext/filters/client_channel/resolver_result_parsing.cc b/src/core/ext/filters/client_channel/resolver_result_parsing.cc index 35e54779c69..452dea6a0f7 100644 --- a/src/core/ext/filters/client_channel/resolver_result_parsing.cc +++ b/src/core/ext/filters/client_channel/resolver_result_parsing.cc @@ -416,8 +416,8 @@ ClientChannelServiceConfigParser::ParseGlobalParams(const grpc_json* json, "field:retryThrottling error:Type should be object")); continue; } - Optional max_milli_tokens = Optional(); - Optional milli_token_ratio = Optional(); + Optional max_milli_tokens; + Optional milli_token_ratio; for (grpc_json* sub_field = field->child; sub_field != nullptr; sub_field = sub_field->next) { if (sub_field->key == nullptr) continue; @@ -535,7 +535,7 @@ ClientChannelServiceConfigParser::ParsePerMethodParams(const grpc_json* json, grpc_error** error) { GPR_DEBUG_ASSERT(error != nullptr && *error == GRPC_ERROR_NONE); InlinedVector error_list; - Optional wait_for_ready = Optional(); + Optional wait_for_ready; grpc_millis timeout = 0; UniquePtr retry_policy; for (grpc_json* field = json->child; field != nullptr; field = field->next) { diff --git a/src/core/lib/gprpp/optional.h b/src/core/lib/gprpp/optional.h index a8e3ce1505e..ab5f86393b6 100644 --- a/src/core/lib/gprpp/optional.h +++ b/src/core/lib/gprpp/optional.h @@ -26,6 +26,7 @@ namespace grpc_core { template class Optional { public: + Optional() : value_() {} void set(const T& val) { value_ = val; set_ = true;