From 5a9a32b74bb112a5ddada6233612b210731b0539 Mon Sep 17 00:00:00 2001 From: ctiller <10120821+ctiller@users.noreply.github.com> Date: Thu, 25 Apr 2024 18:40:04 +0000 Subject: [PATCH 1/2] Automated change: Fix sanity tests --- src/core/lib/transport/transport.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/lib/transport/transport.h b/src/core/lib/transport/transport.h index 6d9fd3eeea2..fe7f72ef1ed 100644 --- a/src/core/lib/transport/transport.h +++ b/src/core/lib/transport/transport.h @@ -569,7 +569,7 @@ class FilterStackTransport : public Transport { grpc_closure* then_schedule_closure) = 0; protected: - ~FilterStackTransport() = default; + ~FilterStackTransport() override = default; }; class ClientTransport : public Transport { @@ -577,7 +577,7 @@ class ClientTransport : public Transport { virtual void StartCall(CallHandler call_handler) = 0; protected: - ~ClientTransport() = default; + ~ClientTransport() override = default; }; class ServerTransport : public Transport { @@ -602,7 +602,7 @@ class ServerTransport : public Transport { virtual void SetAcceptor(Acceptor* acceptor) = 0; protected: - ~ServerTransport() = default; + ~ServerTransport() override = default; }; } // namespace grpc_core From 4d2534702362a0a1d6fdb508ef08424ae379ada2 Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Thu, 25 Apr 2024 22:40:58 +0000 Subject: [PATCH 2/2] x --- src/core/ext/transport/cronet/transport/cronet_transport.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/ext/transport/cronet/transport/cronet_transport.cc b/src/core/ext/transport/cronet/transport/cronet_transport.cc index d215ed860c5..1b8c3d117cf 100644 --- a/src/core/ext/transport/cronet/transport/cronet_transport.cc +++ b/src/core/ext/transport/cronet/transport/cronet_transport.cc @@ -119,8 +119,7 @@ static bidirectional_stream_callback cronet_callbacks = { on_canceled}; // Cronet transport object -struct grpc_cronet_transport final : public grpc_core::Transport, - public grpc_core::FilterStackTransport { +struct grpc_cronet_transport final : public grpc_core::FilterStackTransport { FilterStackTransport* filter_stack_transport() override { return this; } grpc_core::ClientTransport* client_transport() override { return nullptr; } grpc_core::ServerTransport* server_transport() override { return nullptr; }