From 5e3fae7d4b080f60931948c6d05d3e1cba2c84ba Mon Sep 17 00:00:00 2001
From: "Mark D. Roth" <roth@google.com>
Date: Mon, 12 Oct 2020 15:22:48 -0700
Subject: [PATCH] appease clang-tidy

---
 .clang_complete             | 1 +
 src/core/ext/xds/xds_api.cc | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/.clang_complete b/.clang_complete
index 2769e899722..034bea7b2ce 100644
--- a/.clang_complete
+++ b/.clang_complete
@@ -4,6 +4,7 @@
 -Igens
 -Iinclude
 -Isrc/core/ext/upb-generated
+-Isrc/core/ext/upbdefs-generated
 -Ithird_party/abseil-cpp
 -Ithird_party/address_sorting/include
 -Ithird_party/benchmark/include
diff --git a/src/core/ext/xds/xds_api.cc b/src/core/ext/xds/xds_api.cc
index 8c8180828ba..e56e04ddac6 100644
--- a/src/core/ext/xds/xds_api.cc
+++ b/src/core/ext/xds/xds_api.cc
@@ -312,9 +312,11 @@ enum MatchType {
 };
 
 // Returns true if match succeeds.
-bool DomainMatch(MatchType match_type, std::string domain_pattern,
-                 std::string expected_host_name) {
+bool DomainMatch(MatchType match_type, const std::string& domain_pattern_in,
+                 const std::string& expected_host_name_in) {
   // Normalize the args to lower-case. Domain matching is case-insensitive.
+  std::string domain_pattern = domain_pattern_in;
+  std::string expected_host_name = expected_host_name_in;
   std::transform(domain_pattern.begin(), domain_pattern.end(),
                  domain_pattern.begin(),
                  [](unsigned char c) { return std::tolower(c); });