From 5baf2962929a4d886b108ba17b71a0aefff87776 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Fri, 17 Apr 2020 13:27:21 +0200 Subject: [PATCH] add link to Protobuf PHP empty.proto issue --- src/php/bin/generate_proto_php.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/src/php/bin/generate_proto_php.sh b/src/php/bin/generate_proto_php.sh index d7c0a593e4a..3265c29c857 100755 --- a/src/php/bin/generate_proto_php.sh +++ b/src/php/bin/generate_proto_php.sh @@ -29,6 +29,7 @@ $PROTOC --proto_path=src/proto/math \ # replace the Empty message with EmptyMessage # because Empty is a PHP reserved word +# See https://github.com/protocolbuffers/protobuf/issues/2124 output_file=$(mktemp) sed 's/message Empty/message EmptyMessage/g' \ src/proto/grpc/testing/empty.proto > $output_file