Change comment words

pull/19358/head
Yunjia Wang 6 years ago
parent 169d0c8ab9
commit 5955baf3d9
  1. 8
      src/core/lib/iomgr/executor/mpmcqueue.cc
  2. 10
      src/core/lib/iomgr/executor/mpmcqueue.h

@ -22,10 +22,10 @@
namespace grpc_core {
DebugOnlyTraceFlag thread_pool(false, "thread_pool_trace");
DebugOnlyTraceFlag grpc_thread_pool_trace(false, "thread_pool_trace");
inline void* InfLenFIFOQueue::PopFront() {
// Caller should already checked queue is not empty and has already hold the
// Caller should already check queue is not empty and has already held the
// mutex. This function will only do the job of removal.
void* result = queue_head_->content;
Node* head_to_remove = queue_head_;
@ -33,7 +33,7 @@ inline void* InfLenFIFOQueue::PopFront() {
count_.FetchSub(1, MemoryOrder::RELAXED);
if (GRPC_TRACE_FLAG_ENABLED(thread_pool)) {
if (GRPC_TRACE_FLAG_ENABLED(grpc_thread_pool_trace)) {
gpr_timespec wait_time =
gpr_time_sub(gpr_now(GPR_CLOCK_MONOTONIC), head_to_remove->insert_time);
@ -67,8 +67,6 @@ inline void* InfLenFIFOQueue::PopFront() {
return result;
}
InfLenFIFOQueue::InfLenFIFOQueue() {}
InfLenFIFOQueue::~InfLenFIFOQueue() {
GPR_ASSERT(count_.Load(MemoryOrder::RELAXED) == 0);
GPR_ASSERT(num_waiters_ == 0);

@ -28,7 +28,7 @@
namespace grpc_core {
extern DebugOnlyTraceFlag thread_pool;
extern DebugOnlyTraceFlag grpc_thread_pool_trace;
// Abstract base class of a Multiple-Producer-Multiple-Consumer(MPMC) queue
// interface
@ -53,10 +53,10 @@ class MPMCQueueInterface {
class InfLenFIFOQueue : public MPMCQueueInterface {
public:
// Creates a new MPMC Queue. The queue created will have infinite length.
InfLenFIFOQueue();
InfLenFIFOQueue() {}
// Releases all resources hold by the queue. The queue must be empty, and no
// one waiting on conditional variables.
// Releases all resources held by the queue. The queue must be empty, and no
// one waits on conditional variables.
~InfLenFIFOQueue();
// Puts elem into queue immediately at the end of queue. Since the queue has
@ -86,7 +86,7 @@ class InfLenFIFOQueue : public MPMCQueueInterface {
Node(void* c) : content(c) {
next = nullptr;
insert_time = gpr_now(GPR_CLOCK_PRECISE);
insert_time = gpr_now(GPR_CLOCK_MONOTONIC);
}
};

Loading…
Cancel
Save