Chiebot-Mirror
/
grpc
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove host option from ServerConfig proto since it is error-prone and

Browse Source 
may cause inter-language confusion.
pull/4960/head
Vijay Pai 9 years ago
parent 50d012bb82
commit 5919e81ff1
14 changed files with 13 additions and 25 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      src/node/performance/worker_service_impl.js
  2. 2
      src/proto/grpc/testing/control.proto
  3. 3
      test/cpp/qps/async_streaming_ping_pong_test.cc
  4. 3
      test/cpp/qps/async_unary_ping_pong_test.cc
  5. 1
      test/cpp/qps/generic_async_streaming_ping_pong_test.cc
  6. 1
      test/cpp/qps/qps_driver.cc
  7. 3
      test/cpp/qps/qps_openloop_test.cc
  8. 3
      test/cpp/qps/qps_test.cc
  9. 3
      test/cpp/qps/qps_test_with_poll.cc
  10. 3
      test/cpp/qps/secure_sync_unary_ping_pong_test.cc
  11. 2
      test/cpp/qps/server_async.cc
  12. 4
      test/cpp/qps/server_sync.cc
  13. 3
      test/cpp/qps/sync_streaming_ping_pong_test.cc
  14. 3
      test/cpp/qps/sync_unary_ping_pong_test.cc

4
src/node/performance/worker_service_impl.js
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -99,7 +99,7 @@ exports.runServer = function runServer(call) {
var stats; var stats;
switch (request.argtype) { switch (request.argtype) {
case 'setup': case 'setup':
server = new BenchmarkServer(request.setup.host, request.setup.port, server = new BenchmarkServer('[::]', request.setup.port,
request.setup.security_params); request.setup.security_params);
server.start(); server.start();
stats = server.mark(); stats = server.mark();

2
src/proto/grpc/testing/control.proto
Unescape View File

@ -127,8 +127,6 @@ message ClientArgs {
message ServerConfig { message ServerConfig {
ServerType server_type = 1; ServerType server_type = 1;
SecurityParams security_params = 2; SecurityParams security_params = 2;
// Host on which to listen.
string host = 3;
// Port on which to listen. Zero means pick unused port. // Port on which to listen. Zero means pick unused port.
int32 port = 4; int32 port = 4;
// Only for async server. Number of threads used to serve the requests. // Only for async server. Number of threads used to serve the requests.

3
test/cpp/qps/async_streaming_ping_pong_test.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -58,7 +58,6 @@ static void RunAsyncStreamingPingPong() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(ASYNC_SERVER); server_config.set_server_type(ASYNC_SERVER);
server_config.set_host("localhost");
server_config.set_async_server_threads(1); server_config.set_async_server_threads(1);
const auto result = const auto result =

3
test/cpp/qps/async_unary_ping_pong_test.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -58,7 +58,6 @@ static void RunAsyncUnaryPingPong() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(ASYNC_SERVER); server_config.set_server_type(ASYNC_SERVER);
server_config.set_host("localhost");
server_config.set_async_server_threads(1); server_config.set_async_server_threads(1);
const auto result = const auto result =

1
test/cpp/qps/generic_async_streaming_ping_pong_test.cc
Unescape View File

@ -61,7 +61,6 @@ static void RunGenericAsyncStreamingPingPong() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(ASYNC_GENERIC_SERVER); server_config.set_server_type(ASYNC_GENERIC_SERVER);
server_config.set_host("localhost");
server_config.set_async_server_threads(1); server_config.set_async_server_threads(1);
const auto result = const auto result =

1
test/cpp/qps/qps_driver.cc
Unescape View File

@ -153,7 +153,6 @@ static void QpsDriver() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(server_type); server_config.set_server_type(server_type);
server_config.set_host("::"); // Use the wildcard server address
server_config.set_async_server_threads(FLAGS_async_server_threads); server_config.set_async_server_threads(FLAGS_async_server_threads);
if (FLAGS_secure_test) { if (FLAGS_secure_test) {

3
test/cpp/qps/qps_openloop_test.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -59,7 +59,6 @@ static void RunQPS() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(ASYNC_SERVER); server_config.set_server_type(ASYNC_SERVER);
server_config.set_host("localhost");
server_config.set_async_server_threads(4); server_config.set_async_server_threads(4);
const auto result = const auto result =

3
test/cpp/qps/qps_test.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -58,7 +58,6 @@ static void RunQPS() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(ASYNC_SERVER); server_config.set_server_type(ASYNC_SERVER);
server_config.set_host("localhost");
server_config.set_async_server_threads(8); server_config.set_async_server_threads(8);
const auto result = const auto result =

3
test/cpp/qps/qps_test_with_poll.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -62,7 +62,6 @@ static void RunQPS() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(ASYNC_SERVER); server_config.set_server_type(ASYNC_SERVER);
server_config.set_host("localhost");
server_config.set_async_server_threads(4); server_config.set_async_server_threads(4);
const auto result = const auto result =

3
test/cpp/qps/secure_sync_unary_ping_pong_test.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -57,7 +57,6 @@ static void RunSynchronousUnaryPingPong() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(SYNC_SERVER); server_config.set_server_type(SYNC_SERVER);
server_config.set_host("localhost");
// Set up security params // Set up security params
SecurityParams security; SecurityParams security;

2
test/cpp/qps/server_async.cc
Unescape View File

@ -76,7 +76,7 @@ class AsyncQpsServerTest : public Server {
: Server(config) { : Server(config) {
char *server_address = NULL; char *server_address = NULL;
gpr_join_host_port(&server_address, config.host().c_str(), port()); gpr_join_host_port(&server_address, "::", port());
ServerBuilder builder; ServerBuilder builder;
builder.AddListeningPort(server_address, builder.AddListeningPort(server_address,

4
test/cpp/qps/server_sync.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -89,7 +89,7 @@ class SynchronousServer GRPC_FINAL : public grpc::testing::Server {
char* server_address = NULL; char* server_address = NULL;
gpr_join_host_port(&server_address, config.host().c_str(), port()); gpr_join_host_port(&server_address, "::", port());
builder.AddListeningPort(server_address, builder.AddListeningPort(server_address,
Server::CreateServerCredentials(config)); Server::CreateServerCredentials(config));
gpr_free(server_address); gpr_free(server_address);

3
test/cpp/qps/sync_streaming_ping_pong_test.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -57,7 +57,6 @@ static void RunSynchronousStreamingPingPong() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(SYNC_SERVER); server_config.set_server_type(SYNC_SERVER);
server_config.set_host("localhost");
const auto result = const auto result =
RunScenario(client_config, 1, server_config, 1, WARMUP, BENCHMARK, -2); RunScenario(client_config, 1, server_config, 1, WARMUP, BENCHMARK, -2);

3
test/cpp/qps/sync_unary_ping_pong_test.cc
Unescape View File

@ -1,6 +1,6 @@
/* /*
* *
* Copyright 2015, Google Inc. * Copyright 2015-2016, Google Inc.
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -57,7 +57,6 @@ static void RunSynchronousUnaryPingPong() {
ServerConfig server_config; ServerConfig server_config;
server_config.set_server_type(SYNC_SERVER); server_config.set_server_type(SYNC_SERVER);
server_config.set_host("localhost");
const auto result = const auto result =
RunScenario(client_config, 1, server_config, 1, WARMUP, BENCHMARK, -2); RunScenario(client_config, 1, server_config, 1, WARMUP, BENCHMARK, -2);

Write Preview
Loading…
Cancel
Save