[iwyu] Enable nosafe_headers (#29591)

* Add flag

* sweep1

* fixes

* speedup

* fixes

* fix

* fix

* fix

* Automated change: Fix sanity tests

* fix

* fix

* fix

* fix

* fix

* fix

* fix

Co-authored-by: ctiller <ctiller@users.noreply.github.com>

BUILD

@@ -2651,6 +2651,7 @@ grpc_cc_library(
         "grpc_base",
         "idle_filter_state",
         "loop",
+        "promise",
         "single_set_ptr",
         "sleep",
         "try_seq",
@@ -2785,6 +2786,7 @@ grpc_cc_library(
         "gpr_base",
         "grpc_base",
         "grpc_message_size_filter",
+        "promise",
         "seq",
         "slice",
     ],
@@ -3390,6 +3392,7 @@ grpc_cc_library(
         "grpc_lb_policy_grpclb",
         "grpc_security_base",
         "grpc_sockaddr",
+        "promise",
         "seq",
         "slice",
         "uri_parser",
@@ -3773,6 +3776,7 @@ grpc_cc_library(
         "grpc_base",
         "grpc_credentials_util",
         "grpc_trace",
+        "promise",
         "slice_refcount",
         "sockaddr_utils",
     ],
@@ -4381,6 +4385,7 @@ grpc_cc_library(
         "src/core/tsi/ssl_transport_security.h",
     ],
     external_deps = [
+        "absl/memory",
         "absl/strings",
         "libssl",
         "libcrypto",
@@ -5075,6 +5080,7 @@ grpc_cc_library(
         "grpc++_codegen_base",
         "grpc_base",
         "protobuf_duration_upb",
+        "ref_counted",
         "time",
         "xds_orca_service_upb",
         "xds_orca_upb",

src/core/ext/filters/channel_idle/channel_idle_filter.cc

@@ -33,6 +33,7 @@
 #include "src/core/lib/iomgr/timer.h"
 #include "src/core/lib/promise/exec_ctx_wakeup_scheduler.h"
 #include "src/core/lib/promise/loop.h"
+#include "src/core/lib/promise/promise.h"
 #include "src/core/lib/promise/sleep.h"
 #include "src/core/lib/promise/try_seq.h"
 #include "src/core/lib/transport/http2_errors.h"

src/core/ext/filters/http/client/http_client_filter.cc

@@ -29,6 +29,7 @@
 #include "absl/strings/str_format.h"
 #include "absl/strings/str_join.h"
 
+#include <grpc/grpc.h>
 #include <grpc/support/alloc.h>
 #include <grpc/support/log.h>
 

src/core/ext/filters/http/server/http_server_filter.cc

@@ -22,6 +22,7 @@
 
 #include <string.h>
 
+#include <grpc/grpc.h>
 #include <grpc/support/alloc.h>
 #include <grpc/support/log.h>
 
@@ -29,6 +30,7 @@
 #include "src/core/lib/gprpp/manual_constructor.h"
 #include "src/core/lib/profiling/timers.h"
 #include "src/core/lib/promise/call_push_pull.h"
+#include "src/core/lib/promise/promise.h"
 #include "src/core/lib/promise/seq.h"
 #include "src/core/lib/slice/b64.h"
 #include "src/core/lib/slice/percent_encoding.h"

src/core/ext/filters/load_reporting/server_load_reporting_filter.cc

@@ -43,6 +43,7 @@
 #include "src/core/lib/iomgr/resolve_address.h"
 #include "src/core/lib/iomgr/sockaddr.h"
 #include "src/core/lib/iomgr/socket_utils.h"
+#include "src/core/lib/promise/promise.h"
 #include "src/core/lib/promise/seq.h"
 #include "src/core/lib/security/context/security_context.h"
 #include "src/core/lib/slice/slice_internal.h"

src/core/ext/transport/chttp2/client/chttp2_connector.h

@@ -25,7 +25,6 @@
 
 #include "src/core/ext/filters/client_channel/connector.h"
 #include "src/core/lib/channel/handshaker.h"
-#include "src/core/lib/channel/handshaker_registry.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 #include "src/core/lib/gprpp/sync.h"
 #include "src/core/lib/iomgr/closure.h"

src/core/ext/transport/chttp2/transport/bin_decoder.h

@@ -21,7 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
 #include <stddef.h>
 #include <stdint.h>
 

src/core/ext/transport/chttp2/transport/chttp2_transport.cc

@@ -63,7 +63,6 @@
 #include "src/core/lib/gprpp/bitset.h"
 #include "src/core/lib/gprpp/debug_location.h"
 #include "src/core/lib/gprpp/global_config_env.h"
-#include "src/core/lib/gprpp/global_config_generic.h"
 #include "src/core/lib/gprpp/manual_constructor.h"
 #include "src/core/lib/gprpp/orphanable.h"
 #include "src/core/lib/gprpp/ref_counted.h"

src/core/ext/transport/chttp2/transport/context_list.h

@@ -24,7 +24,6 @@
 #include <stddef.h>
 
 #include "src/core/ext/transport/chttp2/transport/frame.h"
-#include "src/core/ext/transport/chttp2/transport/internal.h"
 #include "src/core/lib/iomgr/buffer_list.h"
 #include "src/core/lib/iomgr/error.h"
 

src/core/ext/transport/chttp2/transport/flow_control.h

@@ -28,8 +28,6 @@
 
 #include "src/core/ext/transport/chttp2/transport/http2_settings.h"
 #include "src/core/lib/debug/trace.h"
-#include "src/core/lib/gpr/useful.h"
-#include "src/core/lib/gprpp/manual_constructor.h"
 #include "src/core/lib/gprpp/time.h"
 #include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/transport/bdp_estimator.h"

src/core/ext/transport/chttp2/transport/frame.h

@@ -21,10 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <grpc/slice.h>
-
-#include "src/core/lib/iomgr/error.h"
-
 /* defined in internal.h */
 typedef struct grpc_chttp2_stream grpc_chttp2_stream;
 typedef struct grpc_chttp2_transport grpc_chttp2_transport;

src/core/ext/transport/chttp2/transport/frame_data.h

@@ -26,7 +26,6 @@
 #include <stdint.h>
 
 #include <grpc/slice.h>
-#include <grpc/slice_buffer.h>
 
 #include "src/core/ext/transport/chttp2/transport/frame.h"
 #include "src/core/lib/gprpp/orphanable.h"

src/core/ext/transport/chttp2/transport/frame_goaway.h

@@ -24,7 +24,6 @@
 #include <stdint.h>
 
 #include <grpc/slice.h>
-#include <grpc/slice_buffer.h>
 
 #include "src/core/ext/transport/chttp2/transport/frame.h"
 #include "src/core/lib/iomgr/error.h"

src/core/ext/transport/chttp2/transport/hpack_encoder.h

@@ -32,10 +32,8 @@
 
 #include <grpc/impl/codegen/compression_types.h>
 #include <grpc/slice.h>
-#include <grpc/slice_buffer.h>
 #include <grpc/status.h>
 
-#include "src/core/ext/transport/chttp2/transport/frame.h"
 #include "src/core/ext/transport/chttp2/transport/hpack_constants.h"
 #include "src/core/ext/transport/chttp2/transport/hpack_encoder_table.h"
 #include "src/core/lib/compression/compression_internal.h"

src/core/ext/transport/chttp2/transport/hpack_parser.cc

@@ -56,6 +56,8 @@
 #include "src/core/lib/transport/parsed_metadata.h"
 #include "src/core/lib/transport/transport.h"
 
+// IWYU pragma: no_include <type_traits>
+
 #if __cplusplus > 201103L
 #define GRPC_HPACK_CONSTEXPR_FN constexpr
 #define GRPC_HPACK_CONSTEXPR_VALUE constexpr

src/core/ext/transport/chttp2/transport/hpack_parser.h

@@ -21,7 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stddef.h>
 #include <stdint.h>
 
 #include <vector>
@@ -33,6 +32,8 @@
 #include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/transport/metadata_batch.h"
 
+// IWYU pragma: no_include <type_traits>
+
 namespace grpc_core {
 
 // Top level interface for parsing a sequence of header, continuation frames.

src/core/ext/transport/chttp2/transport/hpack_parser_table.h

@@ -25,10 +25,7 @@
 
 #include <vector>
 
-#include <grpc/slice.h>
-
 #include "src/core/ext/transport/chttp2/transport/hpack_constants.h"
-#include "src/core/lib/gprpp/memory.h"
 #include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/transport/metadata_batch.h"
 #include "src/core/lib/transport/parsed_metadata.h"

src/core/ext/transport/chttp2/transport/http2_settings.h

@@ -23,7 +23,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
 #include <stdint.h>
 
 enum grpc_chttp2_setting_id {

src/core/ext/transport/chttp2/transport/internal.h

@@ -21,8 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <assert.h>
-#include <stdbool.h>
 #include <stddef.h>
 #include <stdint.h>
 

src/core/ext/transport/chttp2/transport/writing.cc

@@ -31,6 +31,8 @@
 #include <grpc/slice_buffer.h>
 #include <grpc/support/log.h>
 
+// IWYU pragma: no_include "src/core/lib/gprpp/orphanable.h"
+
 #include "src/core/ext/transport/chttp2/transport/chttp2_transport.h"
 #include "src/core/ext/transport/chttp2/transport/context_list.h"
 #include "src/core/ext/transport/chttp2/transport/flow_control.h"

src/core/lib/avl/avl.h

@@ -19,7 +19,6 @@
 
 #include <stdlib.h>
 
-#include <algorithm>
 #include <memory>
 #include <utility>
 

src/core/lib/channel/call_tracer.h

@@ -24,12 +24,10 @@
 #include <stdint.h>
 
 #include "absl/status/status.h"
-#include "absl/strings/string_view.h"
 
 #include <grpc/impl/codegen/gpr_types.h>
 #include <grpc/support/atm.h>
 
-#include "src/core/lib/channel/channel_stack.h"
 #include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/transport/byte_stream.h"
 #include "src/core/lib/transport/metadata_batch.h"

src/core/lib/channel/channel_args.h

@@ -31,7 +31,6 @@
 #include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 #include "absl/types/variant.h"
-#include "absl/utility/utility.h"
 
 #include <grpc/impl/codegen/grpc_types.h>
 

src/core/lib/channel/channel_stack.h

@@ -50,13 +50,11 @@
 
 #include <functional>
 
-#include <grpc/grpc.h>
 #include <grpc/impl/codegen/gpr_types.h>
 #include <grpc/impl/codegen/grpc_types.h>
 #include <grpc/slice.h>
 #include <grpc/status.h>
 #include <grpc/support/log.h>
-#include <grpc/support/time.h>
 
 #include "src/core/lib/channel/context.h"
 #include "src/core/lib/debug/trace.h"
@@ -70,7 +68,6 @@
 #include "src/core/lib/iomgr/polling_entity.h"
 #include "src/core/lib/promise/arena_promise.h"
 #include "src/core/lib/resource_quota/arena.h"
-#include "src/core/lib/transport/metadata_batch.h"
 #include "src/core/lib/transport/transport.h"
 
 struct grpc_call_element;

src/core/lib/channel/channel_stack_builder.h

@@ -17,9 +17,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
-
-#include <functional>
 #include <string>
 #include <vector>
 
@@ -30,8 +27,6 @@
 
 #include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
-#include "src/core/lib/iomgr/closure.h"
-#include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/surface/channel_stack_type.h"
 
 typedef struct grpc_channel_stack grpc_channel_stack;

src/core/lib/channel/channel_stack_builder_impl.h

@@ -17,12 +17,8 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
-
 #include "absl/status/statusor.h"
 
-#include "src/core/lib/channel/channel_args.h"
-#include "src/core/lib/channel/channel_stack.h"
 #include "src/core/lib/channel/channel_stack_builder.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 

src/core/lib/channel/channel_trace.h

@@ -24,14 +24,11 @@
 #include <stddef.h>
 #include <stdint.h>
 
-#include <grpc/grpc.h>
 #include <grpc/impl/codegen/gpr_types.h>
 #include <grpc/slice.h>
 #include <grpc/support/sync.h>
 
-#include "src/core/lib/gprpp/ref_counted.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
-#include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/json/json.h"
 
 namespace grpc_core {

src/core/lib/channel/channelz.h

@@ -34,19 +34,15 @@
 #include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 
-#include <grpc/grpc.h>
 #include <grpc/impl/codegen/connectivity_state.h>
 #include <grpc/impl/codegen/grpc_types.h>
 #include <grpc/slice.h>
 
 #include "src/core/lib/channel/channel_trace.h"
 #include "src/core/lib/gpr/time_precise.h"
-#include "src/core/lib/gprpp/manual_constructor.h"
 #include "src/core/lib/gprpp/ref_counted.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 #include "src/core/lib/gprpp/sync.h"
-#include "src/core/lib/iomgr/error.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/json/json.h"
 
 // Channel arg key for channelz node.

src/core/lib/channel/channelz_registry.h

@@ -26,7 +26,6 @@
 #include <map>
 #include <string>
 
-#include "src/core/lib/channel/channel_trace.h"
 #include "src/core/lib/channel/channelz.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 #include "src/core/lib/gprpp/sync.h"

src/core/lib/channel/handshaker.h

@@ -27,9 +27,7 @@
 
 #include <grpc/impl/codegen/grpc_types.h>
 #include <grpc/slice.h>
-#include <grpc/support/string_util.h>
 
-#include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/gprpp/ref_counted.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 #include "src/core/lib/gprpp/sync.h"
@@ -37,7 +35,6 @@
 #include "src/core/lib/iomgr/closure.h"
 #include "src/core/lib/iomgr/endpoint.h"
 #include "src/core/lib/iomgr/error.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/iomgr/tcp_server.h"
 #include "src/core/lib/iomgr/timer.h"
 

src/core/lib/channel/promise_based_filter.h

@@ -30,18 +30,14 @@
 #include <utility>
 
 #include "absl/container/inlined_vector.h"
-#include "absl/functional/function_ref.h"
 #include "absl/meta/type_traits.h"
-#include "absl/utility/utility.h"
 
-#include <grpc/status.h>
 #include <grpc/support/log.h>
 
 #include "src/core/lib/channel/call_finalization.h"
 #include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/channel/channel_stack.h"
 #include "src/core/lib/channel/context.h"
-#include "src/core/lib/gprpp/debug_location.h"
 #include "src/core/lib/gprpp/time.h"
 #include "src/core/lib/iomgr/call_combiner.h"
 #include "src/core/lib/iomgr/closure.h"
@@ -52,7 +48,6 @@
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/latch.h"
 #include "src/core/lib/promise/poll.h"
-#include "src/core/lib/promise/promise.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/transport/error_utils.h"
 #include "src/core/lib/transport/metadata_batch.h"

src/core/lib/channel/status_util.h

@@ -21,9 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
-#include <string.h>
-
 #include <grpc/status.h>
 
 /// If \a status_str is a valid status string, sets \a status to the

src/core/lib/event_engine/memory_allocator.cc

@@ -41,7 +41,7 @@ class SliceRefCount : public grpc_slice_refcount {
   static void Destroy(grpc_slice_refcount* p) {
     auto* rc = static_cast<SliceRefCount*>(p);
     rc->~SliceRefCount();
-    gpr_free(rc);
+    free(rc);
   }
 
   std::shared_ptr<internal::MemoryAllocatorImpl> allocator_;
@@ -52,7 +52,7 @@ class SliceRefCount : public grpc_slice_refcount {
 
 grpc_slice MemoryAllocator::MakeSlice(MemoryRequest request) {
   auto size = Reserve(request.Increase(sizeof(SliceRefCount)));
-  void* p = gpr_malloc(size);
+  void* p = malloc(size);
   new (p) SliceRefCount(allocator_, size);
   grpc_slice slice;
   slice.refcount = static_cast<SliceRefCount*>(p);

src/core/lib/gprpp/bitset.h

@@ -21,7 +21,6 @@
 #include <stdint.h>
 
 #include <type_traits>
-#include <utility>
 
 #include "src/core/lib/gpr/useful.h"
 

src/core/lib/gprpp/capture.h

@@ -19,7 +19,6 @@
 
 #include <tuple>
 #include <type_traits>
-#include <utility>
 
 #include "absl/utility/utility.h"
 

src/core/lib/gprpp/dual_ref_counted.h

@@ -20,13 +20,9 @@
 #include <grpc/support/port_platform.h>
 
 #include <atomic>
-#include <cassert>
-#include <cinttypes>
 #include <cstdint>
 
-#include <grpc/support/atm.h>
 #include <grpc/support/log.h>
-#include <grpc/support/sync.h>
 
 #include "src/core/lib/gprpp/debug_location.h"
 #include "src/core/lib/gprpp/orphanable.h"

src/core/lib/gprpp/examine_stack.h

@@ -21,7 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <functional>
 #include <string>
 
 #include "absl/types/optional.h"

src/core/lib/gprpp/fork.cc

@@ -26,7 +26,6 @@
 #include <grpc/support/time.h>
 
 #include "src/core/lib/gprpp/global_config_env.h"
-#include "src/core/lib/gprpp/global_config_generic.h"
 
 /*
  * NOTE: FORKING IS NOT GENERALLY SUPPORTED, THIS IS ONLY INTENDED TO WORK

src/core/lib/gprpp/global_config.h

@@ -21,8 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdint.h>
-
 // --------------------------------------------------------------------
 // How to use global configuration variables:
 //
@@ -89,7 +87,7 @@
 //   bool gpr_global_config_get_test();
 //   void gpr_global_config_set_test(bool value);
 
-#include "src/core/lib/gprpp/global_config_custom.h"
-#include "src/core/lib/gprpp/global_config_env.h"
+#include "src/core/lib/gprpp/global_config_custom.h"  // IWYU pragma: export
+#include "src/core/lib/gprpp/global_config_env.h"     // IWYU pragma: export
 
 #endif /* GRPC_CORE_LIB_GPRPP_GLOBAL_CONFIG_H */

src/core/lib/gprpp/global_config_env.h

@@ -23,7 +23,7 @@
 
 #include <stdint.h>
 
-#include "src/core/lib/gprpp/global_config_generic.h"
+#include "src/core/lib/gprpp/global_config_generic.h"  // IWYU pragma: export
 #include "src/core/lib/gprpp/memory.h"
 
 namespace grpc_core {

src/core/lib/gprpp/global_config_generic.h

@@ -21,10 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdint.h>
-
-#include "src/core/lib/gprpp/memory.h"
-
 #define GPR_GLOBAL_CONFIG_GET(name) gpr_global_config_get_##name()
 
 #define GPR_GLOBAL_CONFIG_SET(name, value) gpr_global_config_set_##name(value)

src/core/lib/gprpp/manual_constructor.h

@@ -24,7 +24,6 @@
 #include <grpc/support/port_platform.h>
 
 #include <stddef.h>
-#include <stdlib.h>
 
 #include <new>
 #include <type_traits>

src/core/lib/gprpp/memory.h

@@ -21,15 +21,10 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <limits>
 #include <memory>
 #include <type_traits>
-#include <utility>
-
-#include "absl/memory/memory.h"
 
 #include <grpc/support/alloc.h>
-#include <grpc/support/log.h>
 
 namespace grpc_core {
 

src/core/lib/gprpp/orphanable.h

@@ -25,11 +25,7 @@
 #include <memory>
 #include <utility>
 
-#include <grpc/support/log.h>
-#include <grpc/support/sync.h>
-
 #include "src/core/lib/gprpp/debug_location.h"
-#include "src/core/lib/gprpp/memory.h"
 #include "src/core/lib/gprpp/ref_counted.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 

src/core/lib/gprpp/ref_counted.h

@@ -25,13 +25,10 @@
 #include <cassert>
 #include <cinttypes>
 
-#include <grpc/support/atm.h>
 #include <grpc/support/log.h>
-#include <grpc/support/sync.h>
 
 #include "src/core/lib/gprpp/atomic_utils.h"
 #include "src/core/lib/gprpp/debug_location.h"
-#include "src/core/lib/gprpp/memory.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 
 namespace grpc_core {

src/core/lib/gprpp/ref_counted_ptr.h

@@ -26,7 +26,6 @@
 #include <utility>
 
 #include "src/core/lib/gprpp/debug_location.h"
-#include "src/core/lib/gprpp/memory.h"
 
 namespace grpc_core {
 

src/core/lib/gprpp/stat.h

@@ -19,11 +19,9 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdio.h>
 #include <time.h>
 
 #include "absl/status/status.h"
-#include "absl/strings/string_view.h"
 
 namespace grpc_core {
 

src/core/lib/gprpp/stat_posix.cc

@@ -16,6 +16,8 @@
 
 #include <grpc/support/port_platform.h>
 
+// IWYU pragma: no_include <bits/struct_stat.h>
+
 #include <string.h>
 
 #include "absl/status/status.h"

src/core/lib/gprpp/sync.h

@@ -26,10 +26,13 @@
 
 #include <grpc/support/log.h>
 #include <grpc/support/sync.h>
-#include <grpc/support/time.h>
+
+#ifndef GPR_ABSEIL_SYNC
 
 #include "src/core/lib/gprpp/time_util.h"
 
+#endif
+
 // The core library is not accessible in C++ codegen headers, and vice versa.
 // Thus, we need to have duplicate headers with similar functionality.
 // Make sure any change to this file is also reflected in

src/core/lib/gprpp/thd.h

@@ -26,11 +26,6 @@
 #include <stddef.h>
 
 #include <grpc/support/log.h>
-#include <grpc/support/sync.h>
-#include <grpc/support/thd_id.h>
-#include <grpc/support/time.h>
-
-#include "src/core/lib/gprpp/memory.h"
 
 namespace grpc_core {
 namespace internal {

src/core/lib/gprpp/thd_windows.cc

@@ -26,7 +26,9 @@
 
 #include <grpc/support/alloc.h>
 #include <grpc/support/log.h>
+#include <grpc/support/sync.h>
 #include <grpc/support/thd_id.h>
+#include <grpc/support/time.h>
 
 #include "src/core/lib/gpr/tls.h"
 #include "src/core/lib/gprpp/memory.h"

src/core/lib/gprpp/time.h

@@ -19,7 +19,6 @@
 
 #include <stdint.h>
 
-#include <cstdint>
 #include <limits>
 #include <ostream>
 #include <string>

src/core/lib/gprpp/time_util.h

@@ -22,7 +22,6 @@
 #include "absl/time/time.h"
 
 #include <grpc/impl/codegen/gpr_types.h>
-#include <grpc/support/time.h>
 
 namespace grpc_core {
 

src/core/lib/iomgr/tcp_windows.cc

@@ -31,6 +31,7 @@
 #include <grpc/support/string_util.h>
 
 #include "src/core/lib/address_utils/sockaddr_utils.h"
+#include "src/core/lib/gpr/string.h"
 #include "src/core/lib/gpr/useful.h"
 #include "src/core/lib/iomgr/iocp_windows.h"
 #include "src/core/lib/iomgr/sockaddr.h"

src/core/lib/json/json.h

@@ -21,8 +21,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdlib.h>
-
 #include <map>
 #include <string>
 #include <utility>

src/core/lib/json/json_util.h

@@ -34,7 +34,6 @@
 
 #include "src/core/lib/gprpp/time.h"
 #include "src/core/lib/iomgr/error.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/json/json.h"
 
 namespace grpc_core {

src/core/lib/promise/activity.h

@@ -17,14 +17,11 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <atomic>
-#include <functional>
 #include <memory>
-#include <type_traits>
 #include <utility>
 
 #include "absl/base/thread_annotations.h"

src/core/lib/promise/arena_promise.h

@@ -24,8 +24,6 @@
 
 #include "absl/meta/type_traits.h"
 
-#include <grpc/support/log.h>
-
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/poll.h"
 #include "src/core/lib/resource_quota/arena.h"

src/core/lib/promise/context.h

@@ -29,7 +29,7 @@ namespace grpc_core {
 // not contain any members, only exist.
 // The reason for avoiding this is that context types each use a thread local.
 template <typename T>
-struct ContextType;
+struct ContextType;  // IWYU pragma: keep
 
 namespace promise_detail {
 

src/core/lib/promise/detail/basic_join.h

@@ -30,7 +30,6 @@
 
 #include "src/core/lib/gprpp/bitset.h"
 #include "src/core/lib/gprpp/construct_destruct.h"
-#include "src/core/lib/promise/detail/promise_factory.h"
 #include "src/core/lib/promise/detail/promise_like.h"
 #include "src/core/lib/promise/poll.h"
 

src/core/lib/promise/detail/basic_seq.h

@@ -36,8 +36,6 @@
 
 namespace grpc_core {
 namespace promise_detail {
-template <typename F>
-class PromiseLike;
 
 // Helper for SeqState to evaluate some common types to all partial
 // specializations.

src/core/lib/promise/detail/promise_factory.h

@@ -23,7 +23,6 @@
 #include "absl/meta/type_traits.h"
 
 #include "src/core/lib/promise/detail/promise_like.h"
-#include "src/core/lib/promise/poll.h"
 
 // PromiseFactory is an adaptor class.
 //

src/core/lib/promise/latch.h

@@ -19,7 +19,6 @@
 
 #include <grpc/support/log.h>
 
-#include "src/core/lib/promise/activity.h"
 #include "src/core/lib/promise/intra_activity_waiter.h"
 #include "src/core/lib/promise/poll.h"
 

src/core/lib/promise/observable.h

@@ -24,7 +24,6 @@
 #include <type_traits>
 
 #include "absl/base/thread_annotations.h"
-#include "absl/synchronization/mutex.h"
 #include "absl/types/optional.h"
 #include "absl/types/variant.h"
 

src/core/lib/promise/pipe.h

@@ -17,25 +17,13 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <assert.h>
-#include <stddef.h>
 #include <stdint.h>
 
-#include <new>
-#include <type_traits>
-#include <utility>
-
-#include "absl/container/inlined_vector.h"
-#include "absl/status/status.h"
-#include "absl/status/statusor.h"
 #include "absl/types/optional.h"
-#include "absl/types/variant.h"
 
 #include <grpc/support/log.h>
 
-#include "src/core/lib/promise/activity.h"
 #include "src/core/lib/promise/context.h"
-#include "src/core/lib/promise/detail/promise_factory.h"
 #include "src/core/lib/promise/intra_activity_waiter.h"
 #include "src/core/lib/promise/poll.h"
 #include "src/core/lib/resource_quota/arena.h"
@@ -44,10 +32,6 @@ namespace grpc_core {
 
 template <typename T>
 struct Pipe;
-template <typename T>
-class PipeSender;
-template <typename T>
-class PipeReceiver;
 
 namespace pipe_detail {
 

src/core/lib/promise/race.h

@@ -17,7 +17,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <tuple>
 #include <type_traits>
 
 #include "absl/types/variant.h"

src/core/lib/promise/seq.h

@@ -19,8 +19,6 @@
 
 #include <utility>
 
-#include "absl/types/variant.h"
-
 #include "src/core/lib/promise/detail/basic_seq.h"
 #include "src/core/lib/promise/poll.h"
 

src/core/lib/promise/try_seq.h

@@ -17,14 +17,12 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <tuple>
 #include <type_traits>
 #include <utility>
 
 #include "absl/meta/type_traits.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
-#include "absl/types/variant.h"
 
 #include "src/core/lib/promise/detail/basic_seq.h"
 #include "src/core/lib/promise/detail/status.h"

src/core/lib/resource_quota/api.h

@@ -21,7 +21,6 @@
 
 #include <grpc/impl/codegen/grpc_types.h>
 
-#include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/config/core_configuration.h"
 #include "src/core/lib/resource_quota/resource_quota.h"
 

src/core/lib/resource_quota/arena.h

@@ -35,8 +35,6 @@
 #include <utility>
 
 #include <grpc/event_engine/memory_allocator.h>
-#include <grpc/support/alloc.h>
-#include <grpc/support/sync.h>
 
 #include "src/core/lib/gpr/alloc.h"
 #include "src/core/lib/promise/context.h"

src/core/lib/resource_quota/memory_quota.h

@@ -19,15 +19,12 @@
 
 #include <stdint.h>
 
-#include <algorithm>
 #include <atomic>
 #include <cstddef>
 #include <limits>
 #include <memory>
-#include <queue>
 #include <string>
 #include <utility>
-#include <vector>
 
 #include "absl/base/thread_annotations.h"
 #include "absl/strings/string_view.h"
@@ -35,16 +32,13 @@
 
 #include <grpc/event_engine/memory_allocator.h>
 #include <grpc/event_engine/memory_request.h>
-#include <grpc/slice.h>
 #include <grpc/support/log.h>
 
 #include "src/core/lib/gprpp/orphanable.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 #include "src/core/lib/gprpp/sync.h"
-#include "src/core/lib/gprpp/time.h"
 #include "src/core/lib/promise/activity.h"
 #include "src/core/lib/promise/poll.h"
-#include "src/core/lib/resource_quota/trace.h"
 
 namespace grpc_core {
 

src/core/lib/security/authorization/grpc_server_authz_filter.cc

@@ -19,6 +19,7 @@
 #include "absl/strings/str_join.h"
 
 #include "src/core/lib/channel/promise_based_filter.h"
+#include "src/core/lib/promise/promise.h"
 #include "src/core/lib/security/authorization/evaluate_args.h"
 #include "src/core/lib/transport/transport.h"
 

src/core/lib/security/credentials/call_creds_util.cc

@@ -21,6 +21,8 @@
 #include "absl/strings/str_cat.h"
 #include "absl/strings/string_view.h"
 
+#include <grpc/support/string_util.h>
+
 namespace grpc_core {
 
 namespace {

src/core/lib/security/credentials/channel_creds_registry.h

@@ -21,6 +21,7 @@
 
 #include <grpc/impl/codegen/grpc_types.h>
 
+#include "src/core/lib/gprpp/ref_counted_ptr.h"
 #include "src/core/lib/json/json.h"
 
 struct grpc_channel_credentials;

src/core/lib/security/credentials/credentials.h

@@ -29,6 +29,7 @@
 #include <grpc/grpc_security.h>
 #include <grpc/support/sync.h>
 
+#include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/gprpp/ref_counted.h"
 #include "src/core/lib/iomgr/polling_entity.h"
 #include "src/core/lib/promise/arena_promise.h"

src/core/lib/security/credentials/external/aws_external_account_credentials.cc

@@ -21,6 +21,8 @@
 #include "absl/strings/str_join.h"
 #include "absl/strings/str_replace.h"
 
+#include <grpc/support/string_util.h>
+
 #include "src/core/lib/gpr/env.h"
 #include "src/core/lib/http/httpcli_ssl_credentials.h"
 

src/core/lib/security/credentials/external/external_account_credentials.cc

@@ -13,6 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 //
+
 #include <grpc/support/port_platform.h>
 
 #include "src/core/lib/security/credentials/external/external_account_credentials.h"
@@ -25,6 +26,8 @@
 #include "absl/time/clock.h"
 #include "absl/time/time.h"
 
+#include <grpc/support/string_util.h>
+
 #include "src/core/lib/http/httpcli_ssl_credentials.h"
 #include "src/core/lib/http/parser.h"
 #include "src/core/lib/security/credentials/external/aws_external_account_credentials.h"

src/core/lib/security/credentials/external/url_external_account_credentials.cc

@@ -21,6 +21,8 @@
 #include "absl/strings/str_format.h"
 #include "absl/strings/str_split.h"
 
+#include <grpc/support/string_util.h>
+
 #include "src/core/lib/http/httpcli_ssl_credentials.h"
 #include "src/core/lib/transport/error_utils.h"
 

src/core/lib/slice/percent_encoding.h

@@ -28,12 +28,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
-
-#include "absl/types/optional.h"
-
-#include <grpc/slice.h>
-
 #include "src/core/lib/slice/slice.h"
 
 namespace grpc_core {

src/core/lib/slice/slice.h

@@ -48,11 +48,6 @@
 
 namespace grpc_core {
 
-// Forward declarations
-class Slice;
-class StaticSlice;
-class MutableSlice;
-
 namespace slice_detail {
 
 // Returns an empty slice.

src/core/lib/slice/slice_internal.h

@@ -22,7 +22,6 @@
 #include <grpc/support/port_platform.h>
 
 #include <stdint.h>
-#include <string.h>
 
 #include <cstddef>
 #include <string>
@@ -30,12 +29,10 @@
 #include "absl/strings/string_view.h"
 
 #include <grpc/slice.h>
-#include <grpc/slice_buffer.h>
 #include <grpc/support/log.h>
 
 #include "src/core/lib/gpr/murmur_hash.h"
 #include "src/core/lib/gprpp/memory.h"
-#include "src/core/lib/gprpp/ref_counted.h"
 #include "src/core/lib/slice/slice_refcount.h"
 
 void grpc_slice_buffer_reset_and_unref_internal(grpc_slice_buffer* sb);

src/core/lib/slice/slice_refcount.h

@@ -18,12 +18,9 @@
 #include <grpc/support/port_platform.h>
 
 #include <stdint.h>
-#include <string.h>
 
 #include <grpc/slice.h>
-#include <grpc/support/alloc.h>
 
-#include "src/core/lib/gpr/murmur_hash.h"
 #include "src/core/lib/slice/slice_refcount_base.h"
 
 namespace grpc_core {

src/core/lib/slice/slice_refcount_base.h

@@ -21,9 +21,6 @@
 
 #include <atomic>
 
-#include <grpc/slice.h>
-#include <grpc/support/log.h>
-
 // grpc_slice_refcount : A reference count for grpc_slice.
 struct grpc_slice_refcount {
  public:

src/core/lib/slice/slice_split.h

@@ -21,11 +21,7 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
-#include <stddef.h>
-
 #include <grpc/slice.h>
-#include <grpc/slice_buffer.h>
 
 /** Split \a str by the separator \a sep. Results are stored in \a dst, which
  * should be a properly initialized instance. */

src/core/lib/slice/slice_string_helpers.h

@@ -21,14 +21,10 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
-#include <stddef.h>
 #include <stdint.h>
 
 #include <grpc/slice.h>
 
-#include "src/core/lib/gpr/string.h"
-
 /* Calls gpr_dump on a slice. */
 char* grpc_dump_slice(const grpc_slice& slice, uint32_t flags);
 /* Calls gpr_dump on a slice and returns the result as a slice. */

src/core/lib/surface/validate_metadata.cc

@@ -26,6 +26,7 @@
 #include <grpc/grpc.h>
 #include <grpc/support/alloc.h>
 
+#include "src/core/lib/gpr/string.h"
 #include "src/core/lib/gprpp/bitset.h"
 #include "src/core/lib/gprpp/memory.h"
 #include "src/core/lib/iomgr/error.h"

src/core/lib/transport/bdp_estimator.h

@@ -22,8 +22,6 @@
 #include <grpc/support/port_platform.h>
 
 #include <inttypes.h>
-#include <stdbool.h>
-#include <stdint.h>
 
 #include <grpc/impl/codegen/gpr_types.h>
 #include <grpc/support/log.h>
@@ -31,7 +29,6 @@
 
 #include "src/core/lib/debug/trace.h"
 #include "src/core/lib/gprpp/time.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
 
 extern grpc_core::TraceFlag grpc_bdp_estimator_trace;
 

src/core/lib/transport/byte_stream.h

@@ -25,7 +25,6 @@
 #include <stdint.h>
 
 #include <grpc/slice.h>
-#include <grpc/slice_buffer.h>
 
 #include "src/core/lib/gprpp/orphanable.h"
 #include "src/core/lib/iomgr/closure.h"

src/core/lib/transport/connectivity_state.h

@@ -28,13 +28,10 @@
 
 #include "absl/status/status.h"
 
-#include <grpc/grpc.h>
 #include <grpc/impl/codegen/connectivity_state.h>
 
 #include "src/core/lib/debug/trace.h"
 #include "src/core/lib/gprpp/orphanable.h"
-#include "src/core/lib/iomgr/closure.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/iomgr/work_serializer.h"
 
 namespace grpc_core {

src/core/lib/transport/error_utils.h

@@ -29,7 +29,6 @@
 
 #include "src/core/lib/gprpp/time.h"
 #include "src/core/lib/iomgr/error.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/transport/http2_errors.h"
 
 /// A utility function to get the status code and message to be returned

src/core/lib/transport/metadata_batch.h

@@ -21,13 +21,11 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdbool.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include <algorithm>
 #include <cstdint>
-#include <limits>
 #include <string>
 #include <type_traits>
 #include <utility>
@@ -41,12 +39,9 @@
 #include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 
-#include <grpc/grpc.h>
 #include <grpc/impl/codegen/compression_types.h>
-#include <grpc/slice.h>
 #include <grpc/status.h>
 #include <grpc/support/log.h>
-#include <grpc/support/time.h>
 
 #include "src/core/lib/compression/compression_internal.h"
 #include "src/core/lib/gprpp/chunked_vector.h"
@@ -55,12 +50,9 @@
 #include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/slice/slice.h"
-#include "src/core/lib/surface/validate_metadata.h"
 #include "src/core/lib/transport/parsed_metadata.h"
 #include "src/core/lib/transport/timeout_encoding.h"
 
-struct grpc_call_final_info;
-
 namespace grpc_core {
 
 // grpc-timeout metadata trait.

src/core/lib/transport/parsed_metadata.h

@@ -33,9 +33,7 @@
 #include <grpc/slice.h>
 
 #include "src/core/lib/gprpp/time.h"
-#include "src/core/lib/iomgr/error.h"
 #include "src/core/lib/slice/slice.h"
-#include "src/core/lib/surface/validate_metadata.h"
 
 namespace grpc_core {
 

src/core/lib/transport/status_conversion.h

@@ -21,11 +21,9 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <grpc/grpc.h>
 #include <grpc/status.h>
 
 #include "src/core/lib/gprpp/time.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/transport/http2_errors.h"
 
 /* Conversion of grpc status codes to http2 error codes (for RST_STREAM) */

src/core/lib/transport/timeout_encoding.h

@@ -26,7 +26,6 @@
 #include "absl/types/optional.h"
 
 #include "src/core/lib/gprpp/time.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/slice/slice.h"
 
 namespace grpc_core {

src/core/lib/transport/transport.h

@@ -50,13 +50,11 @@
 #include "src/core/lib/iomgr/iomgr_fwd.h"
 #include "src/core/lib/iomgr/polling_entity.h"
 #include "src/core/lib/iomgr/pollset.h"
-#include "src/core/lib/iomgr/pollset_set.h"
 #include "src/core/lib/promise/arena_promise.h"
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/latch.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/slice/slice.h"
-#include "src/core/lib/slice/slice_internal.h"
 #include "src/core/lib/transport/byte_stream.h"
 #include "src/core/lib/transport/connectivity_state.h"
 #include "src/core/lib/transport/metadata_batch.h"

src/core/lib/transport/transport_impl.h

@@ -29,7 +29,6 @@
 #include "src/core/lib/iomgr/endpoint.h"
 #include "src/core/lib/iomgr/iomgr_fwd.h"
 #include "src/core/lib/iomgr/pollset.h"
-#include "src/core/lib/iomgr/pollset_set.h"
 #include "src/core/lib/promise/arena_promise.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/transport/transport.h"

src/core/lib/uri/uri_parser.h

@@ -19,8 +19,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stddef.h>
-
 #include <map>
 #include <string>
 #include <vector>

src/core/tsi/ssl/session_cache/ssl_session.h

@@ -21,6 +21,8 @@
 
 #include <grpc/support/port_platform.h>
 
+#include <memory>
+
 #include <openssl/ssl.h>
 
 #include <grpc/slice.h>

src/core/tsi/ssl/session_cache/ssl_session_boringssl.cc

@@ -22,6 +22,8 @@
 
 #ifdef OPENSSL_IS_BORINGSSL
 
+#include "absl/memory/memory.h"
+
 // BoringSSL allows SSL_SESSION to outlive SSL and SSL_CTX objects which are
 // re-created by gRPC on every certificate rotation or subchannel creation.
 // BoringSSL guarantees that SSL_SESSION is immutable so it's safe to share

src/core/tsi/ssl/session_cache/ssl_session_openssl.cc

@@ -24,6 +24,8 @@
 
 #ifndef OPENSSL_IS_BORINGSSL
 
+#include "absl/memory/memory.h"
+
 // OpenSSL invalidates SSL_SESSION on SSL destruction making it pointless
 // to cache sessions. The workaround is to serialize (relatively expensive)
 // session into binary blob and re-create it from blob on every handshake.