Fix asan bug.

8 years ago · 590d08ba6f
parent 30d3a6892d
commit 590d08ba6f
1 changed files with 4 additions and 2 deletions
--- a/src/core/ext/client_channel/client_channel.c
+++ b/src/core/ext/client_channel/client_channel.c
@ -547,8 +547,10 @@ static grpc_error *cc_init_channel_elem(grpc_exec_ctx *exec_ctx,
  GPR_ASSERT(arg != NULL);
  GPR_ASSERT(arg->type == GRPC_ARG_STRING);
  grpc_uri *uri = grpc_uri_parse(arg->value.string, true);
-  if (uri == NULL || uri->path[0] == '\0') {
-    return GRPC_ERROR_CREATE("cannot parse server URI");
+  if (uri == NULL) return GRPC_ERROR_CREATE("cannot parse server URI");
+  if (uri->path[0] == '\0') {
+    grpc_uri_destroy(uri);
+    return GRPC_ERROR_CREATE("server URI is missing path");
  }
  chand->server_name =
      gpr_strdup(uri->path[0] == '/' ? uri->path + 1 : uri->path);