mirror of https://github.com/grpc/grpc.git
[channel] Separate call size estimation out of `grpc_core::Channel` (#35732)
Closes #35732
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35732 from ctiller:chan 0d7a29fc77
PiperOrigin-RevId: 602865976
pull/35664/head
Craig Tiller
10 months ago
committed by
Copybara-Service
parent
7b947ec227
commit
59004b4931
20 changed files with 144 additions and 36 deletions
@ -0,0 +1,41 @@ |
||||
// Copyright 2024 gRPC authors.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
|
||||
#include <grpc/support/port_platform.h> |
||||
|
||||
#include "src/core/lib/transport/call_size_estimator.h" |
||||
|
||||
#include <algorithm> |
||||
|
||||
namespace grpc_core { |
||||
|
||||
void CallSizeEstimator::UpdateCallSizeEstimate(size_t size) { |
||||
size_t cur = call_size_estimate_.load(std::memory_order_relaxed); |
||||
if (cur < size) { |
||||
// size grew: update estimate
|
||||
call_size_estimate_.compare_exchange_weak( |
||||
cur, size, std::memory_order_relaxed, std::memory_order_relaxed); |
||||
// if we lose: never mind, something else will likely update soon enough
|
||||
} else if (cur == size) { |
||||
// no change: holding pattern
|
||||
} else if (cur > 0) { |
||||
// size shrank: decrease estimate
|
||||
call_size_estimate_.compare_exchange_weak( |
||||
cur, std::min(cur - 1, (255 * cur + size) / 256), |
||||
std::memory_order_relaxed, std::memory_order_relaxed); |
||||
// if we lose: never mind, something else will likely update soon enough
|
||||
} |
||||
} |
||||
|
||||
} // namespace grpc_core
|
||||
@ -0,0 +1,52 @@ |
||||
// Copyright 2024 gRPC authors.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||
// you may not use this file except in compliance with the License.
|
||||
// You may obtain a copy of the License at
|
||||
//
|
||||
// http://www.apache.org/licenses/LICENSE-2.0
|
||||
//
|
||||
// Unless required by applicable law or agreed to in writing, software
|
||||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
// See the License for the specific language governing permissions and
|
||||
// limitations under the License.
|
||||
|
||||
#ifndef GRPC_SRC_CORE_LIB_TRANSPORT_CALL_SIZE_ESTIMATOR_H |
||||
#define GRPC_SRC_CORE_LIB_TRANSPORT_CALL_SIZE_ESTIMATOR_H |
||||
|
||||
#include <grpc/support/port_platform.h> |
||||
|
||||
#include <stddef.h> |
||||
|
||||
#include <atomic> |
||||
|
||||
namespace grpc_core { |
||||
|
||||
class CallSizeEstimator { |
||||
public: |
||||
explicit CallSizeEstimator(size_t initial_estimate) |
||||
: call_size_estimate_(initial_estimate) {} |
||||
|
||||
size_t CallSizeEstimate() { |
||||
// We round up our current estimate to the NEXT value of kRoundUpSize.
|
||||
// This ensures:
|
||||
// 1. a consistent size allocation when our estimate is drifting slowly
|
||||
// (which is common) - which tends to help most allocators reuse memory
|
||||
// 2. a small amount of allowed growth over the estimate without hitting
|
||||
// the arena size doubling case, reducing overall memory usage
|
||||
static constexpr size_t kRoundUpSize = 256; |
||||
return (call_size_estimate_.load(std::memory_order_relaxed) + |
||||
2 * kRoundUpSize) & |
||||
~(kRoundUpSize - 1); |
||||
} |
||||
|
||||
void UpdateCallSizeEstimate(size_t size); |
||||
|
||||
private: |
||||
std::atomic<size_t> call_size_estimate_; |
||||
}; |
||||
|
||||
} // namespace grpc_core
|
||||
|
||||
#endif // GRPC_SRC_CORE_LIB_TRANSPORT_CALL_SIZE_ESTIMATOR_H
|
||||
Loading…
Reference in new issue