Merge pull request #4744 from dgquintas/check_newlines
Added sanity check for trailing newlinespull/4683/head^2
Craig Tiller
9 years ago
commit
57633ea87b
19 changed files with 99 additions and 32 deletions
@ -0,0 +1,67 @@ |
||||
#!/bin/bash |
||||
# Copyright 2016, Google Inc. |
||||
# All rights reserved. |
||||
# |
||||
# Redistribution and use in source and binary forms, with or without |
||||
# modification, are permitted provided that the following conditions are |
||||
# met: |
||||
# |
||||
# * Redistributions of source code must retain the above copyright |
||||
# notice, this list of conditions and the following disclaimer. |
||||
# * Redistributions in binary form must reproduce the above |
||||
# copyright notice, this list of conditions and the following disclaimer |
||||
# in the documentation and/or other materials provided with the |
||||
# distribution. |
||||
# * Neither the name of Google Inc. nor the names of its |
||||
# contributors may be used to endorse or promote products derived from |
||||
# this software without specific prior written permission. |
||||
# |
||||
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
||||
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
||||
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
||||
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
||||
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
||||
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
||||
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
||||
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
||||
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
||||
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
||||
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
||||
|
||||
# change to root directory |
||||
cd $(dirname $0)/../.. |
||||
|
||||
function find_without_newline() { |
||||
find . -type f -not -path './third_party/*' -and \( \ |
||||
-name '*.c' \ |
||||
-or -name '*.cc' \ |
||||
-or -name '*.proto' \ |
||||
-or -name '*.rb' \ |
||||
-or -name '*.py' \ |
||||
-or -name '*.cs' \ |
||||
-or -name '*.sh' \) -print0 \ |
||||
| while IFS= read -r -d '' f; do |
||||
if [[ ! -z $f ]]; then |
||||
if [[ $(tail -c 1 "$f") != $NEWLINE ]]; then |
||||
echo "Error: file '$f' is missing a trailing newline character." |
||||
if $2; then # fix |
||||
sed -i -e '$a\' $f |
||||
echo 'Fixed!' |
||||
fi |
||||
fi |
||||
fi |
||||
done |
||||
} |
||||
|
||||
if [[ $# == 1 && $1 == '--fix' ]]; then |
||||
ERRORS=$(find_without_newline true) |
||||
else |
||||
ERRORS=$(find_without_newline false) |
||||
fi |
||||
|
||||
if [[ "$ERRORS" != '' ]]; then |
||||
echo "$ERRORS" |
||||
if ! $FIX; then |
||||
exit 1 |
||||
fi |
||||
fi |
||||
Loading…
Reference in new issue