From 55c13844d980b106c508ae2770a350745e146834 Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Wed, 10 Jan 2024 09:48:13 -0800 Subject: [PATCH] [call-v3] Move `ServerLoadReportingFilter` to new registration mechanism (#35501) Closes #35501 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35501 from ctiller:tpl2 9834ee4ae2e9b8d4dc01f57796a75da367b1c6b0 PiperOrigin-RevId: 597277587 --- .../filters/load_reporting/server_load_reporting_filter.cc | 6 ++---- .../filters/load_reporting/server_load_reporting_filter.h | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/ext/filters/load_reporting/server_load_reporting_filter.cc b/src/core/ext/filters/load_reporting/server_load_reporting_filter.cc index 4957d05ddaa..624ca70e79e 100644 --- a/src/core/ext/filters/load_reporting/server_load_reporting_filter.cc +++ b/src/core/ext/filters/load_reporting/server_load_reporting_filter.cc @@ -244,11 +244,9 @@ void ServerLoadReportingFilter::Call::OnFinalize( GetStatusTagForStatus(final_info->final_status)}}); } -namespace { -const grpc_channel_filter kFilter = +const grpc_channel_filter ServerLoadReportingFilter::kFilter = MakePromiseBasedFilter( "server_load_reporting"); -} // namespace // TODO(juanlishen): We should register the filter during grpc initialization // time once OpenCensus is compatible with our build system. For now, we force @@ -266,7 +264,7 @@ struct ServerLoadReportingFilterStaticRegistrar { grpc::load_reporter::MeasureEndLatencyMs(); grpc::load_reporter::MeasureOtherCallMetric(); builder->channel_init() - ->RegisterFilter(GRPC_SERVER_CHANNEL, &kFilter) + ->RegisterFilter(GRPC_SERVER_CHANNEL) .IfChannelArg(GRPC_ARG_ENABLE_LOAD_REPORTING, false); }); } diff --git a/src/core/ext/filters/load_reporting/server_load_reporting_filter.h b/src/core/ext/filters/load_reporting/server_load_reporting_filter.h index f3b8a04db08..ddb8d0f2482 100644 --- a/src/core/ext/filters/load_reporting/server_load_reporting_filter.h +++ b/src/core/ext/filters/load_reporting/server_load_reporting_filter.h @@ -37,6 +37,8 @@ namespace grpc_core { class ServerLoadReportingFilter : public ImplementChannelFilter { public: + static const grpc_channel_filter kFilter; + static absl::StatusOr Create( const ChannelArgs& args, ChannelFilter::Args);