Merge pull request #8450 from dgquintas/move_unref

Moved unref of security connector outside of grpc_secure_channel_create
8 years ago · 54b409c0da
parent 8269d7d16d 30bce6ab1b
commit 54b409c0da
1 changed files with 3 additions and 2 deletions
--- a/src/core/ext/transport/chttp2/client/secure/secure_channel_create.c
+++ b/src/core/ext/transport/chttp2/client/secure/secure_channel_create.c
@ -290,8 +290,6 @@ static grpc_channel *client_channel_factory_create_channel(
    channel = NULL;
  }

-  GRPC_SECURITY_CONNECTOR_UNREF(&f->security_connector->base,
-                                "client_channel_factory_create_channel");
  return channel;
 }

@ -360,6 +358,9 @@ grpc_channel *grpc_secure_channel_create(grpc_channel_credentials *creds,
  grpc_channel *channel = client_channel_factory_create_channel(
      &exec_ctx, &f->base, target, GRPC_CLIENT_CHANNEL_TYPE_REGULAR, NULL);

+  GRPC_SECURITY_CONNECTOR_UNREF(&f->security_connector->base,
+                                "client_channel_factory_create_channel");
+
  grpc_client_channel_factory_unref(&exec_ctx, &f->base);
  grpc_exec_ctx_finish(&exec_ctx);