Merge pull request #18177 from tuanvcw/fixing_typos

Fix some typos in test code
pull/18208/head
Jan Tattermusch 6 years ago committed by GitHub
commit 547b20037f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      test/core/end2end/bad_server_response_test.cc
  2. 2
      test/core/end2end/tests/bad_ping.cc
  3. 2
      test/core/tsi/alts/handshaker/alts_tsi_utils_test.cc
  4. 2
      test/cpp/interop/metrics_client.cc
  5. 2
      test/cpp/naming/address_sorting_test.cc

@ -65,7 +65,7 @@
#define HTTP1_DETAIL_MSG "Trying to connect an http1.x server" #define HTTP1_DETAIL_MSG "Trying to connect an http1.x server"
/* TODO(zyc) Check the content of incomming data instead of using this length */ /* TODO(zyc) Check the content of incoming data instead of using this length */
/* The 'bad' server will start sending responses after reading this amount of /* The 'bad' server will start sending responses after reading this amount of
* data from the client. */ * data from the client. */
#define SERVER_INCOMING_DATA_LENGTH_LOWER_THRESHOLD (size_t)200 #define SERVER_INCOMING_DATA_LENGTH_LOWER_THRESHOLD (size_t)200

@ -312,7 +312,7 @@ static void test_pings_without_data(grpc_end2end_test_config config) {
CQ_EXPECT_COMPLETION(cqv, tag(101), 1); CQ_EXPECT_COMPLETION(cqv, tag(101), 1);
cq_verify(cqv); cq_verify(cqv);
// Send too many pings to the server similar to the prevous test case. // Send too many pings to the server similar to the previous test case.
// However, since we set the MAX_PINGS_WITHOUT_DATA at the client side, only // However, since we set the MAX_PINGS_WITHOUT_DATA at the client side, only
// MAX_PING_STRIKES will actually be sent and the rpc will still succeed. // MAX_PING_STRIKES will actually be sent and the rpc will still succeed.
int i; int i;

@ -51,7 +51,7 @@ static void deserialize_response_test() {
GPR_ASSERT(grpc_gcp_handshaker_resp_equals(resp, decoded_resp)); GPR_ASSERT(grpc_gcp_handshaker_resp_equals(resp, decoded_resp));
grpc_byte_buffer_destroy(buffer); grpc_byte_buffer_destroy(buffer);
/* Invalid serializaiton. */ /* Invalid serialization. */
grpc_slice bad_slice = grpc_slice bad_slice =
grpc_slice_split_head(&slice, GRPC_SLICE_LENGTH(slice) - 1); grpc_slice_split_head(&slice, GRPC_SLICE_LENGTH(slice) - 1);
buffer = grpc_raw_byte_buffer_create(&bad_slice, 1 /* number of slices */); buffer = grpc_raw_byte_buffer_create(&bad_slice, 1 /* number of slices */);

@ -88,7 +88,7 @@ bool PrintMetrics(std::unique_ptr<MetricsService::Stub> stub, bool total_only,
int main(int argc, char** argv) { int main(int argc, char** argv) {
grpc::testing::InitTest(&argc, &argv, true); grpc::testing::InitTest(&argc, &argv, true);
// The output of metrics client is in some cases programatically parsed (for // The output of metrics client is in some cases programmatically parsed (for
// example by the stress test framework). So, we do not want any of the log // example by the stress test framework). So, we do not want any of the log
// from the grpc library appearing on stdout. // from the grpc library appearing on stdout.
gpr_set_log_function(BlackholeLogger); gpr_set_log_function(BlackholeLogger);

@ -790,7 +790,7 @@ TEST_F(AddressSortingTest, TestPrefersIpv6LoopbackInputsFlipped) {
/* Try to rule out false positives in the above two tests in which /* Try to rule out false positives in the above two tests in which
* the sorter might think that neither ipv6 or ipv4 loopback is * the sorter might think that neither ipv6 or ipv4 loopback is
* available, but ipv6 loopback is still preferred only due * available, but ipv6 loopback is still preferred only due
* to precedance table lookups. */ * to precedence table lookups. */
TEST_F(AddressSortingTest, TestSorterKnowsIpv6LoopbackIsAvailable) { TEST_F(AddressSortingTest, TestSorterKnowsIpv6LoopbackIsAvailable) {
sockaddr_in6 ipv6_loopback; sockaddr_in6 ipv6_loopback;
memset(&ipv6_loopback, 0, sizeof(ipv6_loopback)); memset(&ipv6_loopback, 0, sizeof(ipv6_loopback));

Loading…
Cancel
Save